config: runtime: base: python: make more generic #2909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base `python` template was designed with post-checkout jobs (`kbuild`, `kunit`...) in mind and doesn't work too well with test or post-processing jobs due to the following issues: * it assumes we need the kernel source from the parent `checkout` node * it doesn't provide a way to retrieve arbitrary artifacts from a node or its parent * the `_get_source()` function doesn't allow specifying an arbitrary target folder to extract tarballs to Ensure we only download/extract/cd to the kernel source if the current node is a child to a `checkout` node, otherwise let the job definition prepare its workspace as needed. Also add a generic `_get_artifact_url()` for downloading arbitrary artifacts and make the existing `_get_tarball_url()` use it to avoid duplicating code. Finally, add an optional `path` parameter to `_get_source()` so the job can specify the destination folder if needed. Signed-off-by: Arnaud Ferraris <[email protected]>
a-wai
force-pushed
the
generic-python-basejob-fixes
branch
from
b55abb1 to
88a1594
Compare
pawiecz
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base
pythontemplate was designed with post-checkout jobs (kbuild,kunit...) in mind and doesn't work too well with test or post-processing jobs due to the following issues:checkoutnode_get_source()function doesn't allow specifying an arbitrary target folder to extract tarballs toEnsure we only download/extract/cd to the kernel source if the current node is a child to a
checkoutnode, otherwise let the job definition prepare its workspace as needed.Also add a generic
_get_artifact_url()for downloading arbitrary artifacts and make the existing_get_tarball_url()use it to avoid duplicating code.Finally, add an optional
pathparameter to_get_source()so the job can specify the destination folder if needed.