-
Notifications
You must be signed in to change notification settings - Fork 8
Implement command to validate builds #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c8c00e6
to
99f9ec1
Compare
I am getting this when running the command without arguments:
Guess we need to throw a clear error message guiding the user. |
99f9ec1
to
6d8d4a9
Compare
Thanks. Addressed this. |
For starters, the command will work by providing git URL, branch, and commit.
|
6d8d4a9
to
faef030
Compare
faef030
to
54c647f
Compare
Modified directory structure, refactored the code and commands.
Both commands will provide below information:
Sample result:
Note: The |
Thanks for this, @JenySadadia. As for the overall command structure. I have been thinking that we need to create So I suggest:
Now looking at the options you added, my suggestion would be:
Let's also make the output a bit more standard:
|
When using |
54c647f
to
aa67aa2
Compare
Yes, makes sense.
Thanks for the suggestion. Addressed this.
|
873f2ae
to
bb20725
Compare
Thanks for the comment. Addressed this. |
bb20725
to
55b5f33
Compare
That is not so important for this usecase. validate-builds will be more a of backend validation tool for maestro, so not the usual kernel dev doing his development. |
I had found it useful when testing to get the information directly from the current folder instead of adding it by hand each time |
@padovan Are we supposed to see
|
@aliceinwire I reformatted output to be nicer:
|
67b1310
to
8ea4f82
Compare
I believe that just putting a list of ids would be enough, or a list of id + link to our maestro api viewer, otherwise the output will be quite verbose. |
Would be good to have by default a list of ids and have a |
8ea4f82
to
6b883f1
Compare
Thanks for the suggestion. Added |
you added the commit Enable --days switch for getting tree listEnable --days switch for getting tree list of a different PR on this PR |
Yes, this PR depends on 2 other PRs. |
Thanks for the PR @JenySadadia. I found a few issues:
maybe it could be:
|
2c0f26b
to
586322c
Compare
Thank you for testing the PR and feedback.
The patch doesn't look for local git repo when URL, branch, and commit are provided.
Thanks for the suggestion. Yes, I'll work on reformatting the output once I stabilize the command's results. |
Yes, this should be fixed too. |
9383dbd
to
14d1afd
Compare
@padovan I have reformatted the output.
|
For the command `kci-dev results trees`, add `--days` option to provide a period of time in days to get results for. Signed-off-by: Jeny Sadadia <[email protected]>
Make `kci_msg_*` functions more generic in terms of new line at the end of the message. Add a parameter to specify new line requirement while printing message on terminal. Update all related existing function calls. Signed-off-by: Jeny Sadadia <[email protected]>
Replace `kci_msg` prints in `set_giturl_branch_commit` with `logging.info` to avoid having too verbose output on the terminal. Signed-off-by: Jeny Sadadia <[email protected]>
8c1d86b
to
abfc37b
Compare
It looks good to me! Thanks for reworking it! |
Okay. Thanks :) |
@aliceinwire Could you please review the PR? |
Get builds from dashboard and validate them with maestro result. Command introduced with the commit: `kci-dev validate build --all-checkouts --giturl <URL> \ --commit <commit-hash> --branch <git-branch>` Provide `--all-checkouts` to build validation stats for all available checkouts. Build validation for a specific checkout can be performed by using all three options: --giturl, --branch, and --commit. The command will provide below information: 1. Build count validation 2. Missing build information 3. Build status validation Used python package `tabulate` to generate build stats report in tabular format. Signed-off-by: Jeny Sadadia <[email protected]>
abfc37b
to
96af022
Compare
Closes #171
Get builds from dashboard and validate it with maestro result.
PR created on top of #177 and #179
Depends on kernelci/kernelci-api#615