Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflow] Add workflow to automatically bump the s390x runner version #11

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

chantra
Copy link
Contributor

@chantra chantra commented Jan 18, 2023

Get the last release from GH API and update the relevant line in the Dockerfile

@chantra chantra force-pushed the s390x_auto_version_bump branch from 6ea1b31 to 96e85bf Compare January 18, 2023 19:59
@chantra
Copy link
Contributor Author

chantra commented Jan 18, 2023

Tested by merging in chantra/runner in chantra@53b9814

Started the workflow manually (workflow_dispatch event) on main branch
https://github.com/chantra/runner/actions/runs/3952462711
which generated chantra@9cdba02

Copy link

@danielocfb danielocfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that approach-wise this is probably fine, but I am a little hesitant about having some workflow just bump a version without anybody noticing. Not that it is necessarily much different right now, but it's also not great right now :-)
Is there a way for us to create a pull request instead? (Edit: I inferred that the action in question just pushes; if it already creates a pull request then that's fine, but that was not my reading of the docs)

@danielocfb
Copy link

Also, just curious, but have you tested what happens when the version stays the same? Does the action just not create a commit and do nothing?

@chantra
Copy link
Contributor Author

chantra commented Jan 19, 2023

Also, just curious, but have you tested what happens when the version stays the same? Does the action just not create a commit and do nothing?

that's what the action documentation says, yes. https://github.com/marketplace/actions/git-auto-commit

@chantra
Copy link
Contributor Author

chantra commented Jan 19, 2023

I suppose that approach-wise this is probably fine, but I am a little hesitant about having some workflow just bump a version without anybody noticing. Not that it is necessarily much different right now, but it's also not great right now :-) Is there a way for us to create a pull request instead? (Edit: I inferred that the action in question just pushes; if it already creates a pull request then that's fine, but that was not my reading of the docs)

yes, currently, at least for the non s390x, upstream eventualy update the version and it trickles down to us.
I don't think the current action I am using can create a PR, but maybe another one, I would have to search for it.

@chantra chantra force-pushed the s390x_auto_version_bump branch 5 times, most recently from d4a7432 to 8837e5e Compare January 26, 2023 02:02
@chantra
Copy link
Contributor Author

chantra commented Jan 26, 2023

Ok, I found peter-evans/create-pull-request@v4 which is similar and just create PRs.

Tested on my repo.

PR created: chantra#15
actual run:
https://github.com/chantra/runner/actions/runs/4011625579

@chantra chantra requested a review from danielocfb January 26, 2023 02:05
@chantra
Copy link
Contributor Author

chantra commented Jan 26, 2023

I am less sure if the team-reviewers feature will work or not, let see if on next run that creates a PR.

Copy link

@danielocfb danielocfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!


# This workflow pulls the latest official actions runner version using GH API
# and update our s390x Dockerfile.
# If a change happens, the chnage will be commited.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo; should this sentence have to be updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Get the last release from GH API and update the relevant line in the
Dockerfile
Then create a PR and add a set of reviewers to the PR.
@chantra chantra force-pushed the s390x_auto_version_bump branch from 8837e5e to cc94828 Compare January 26, 2023 18:19
@chantra chantra merged commit 1ad11e8 into kernel-patches:main Jan 26, 2023
@chantra chantra deleted the s390x_auto_version_bump branch January 26, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants