-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workflow] Add workflow to automatically bump the s390x runner version #11
Conversation
6ea1b31
to
96e85bf
Compare
Tested by merging in chantra/runner in chantra@53b9814 Started the workflow manually (workflow_dispatch event) on main branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that approach-wise this is probably fine, but I am a little hesitant about having some workflow just bump a version without anybody noticing. Not that it is necessarily much different right now, but it's also not great right now :-)
Is there a way for us to create a pull request instead? (Edit: I inferred that the action in question just pushes; if it already creates a pull request then that's fine, but that was not my reading of the docs)
Also, just curious, but have you tested what happens when the version stays the same? Does the action just not create a commit and do nothing? |
that's what the action documentation says, yes. https://github.com/marketplace/actions/git-auto-commit |
yes, currently, at least for the non s390x, upstream eventualy update the version and it trickles down to us. |
d4a7432
to
8837e5e
Compare
Ok, I found peter-evans/create-pull-request@v4 which is similar and just create PRs. Tested on my repo. PR created: chantra#15 |
I am less sure if the team-reviewers feature will work or not, let see if on next run that creates a PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
.github/workflows/version_bump.yml
Outdated
|
||
# This workflow pulls the latest official actions runner version using GH API | ||
# and update our s390x Dockerfile. | ||
# If a change happens, the chnage will be commited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo; should this sentence have to be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Get the last release from GH API and update the relevant line in the Dockerfile Then create a PR and add a set of reviewers to the PR.
8837e5e
to
cc94828
Compare
Get the last release from GH API and update the relevant line in the Dockerfile