selftests/bpf: Fix arena_spin_lock compilation on PowerPC #8652
+4,456
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: a68894a |
|
Upstream branch: a68894a |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/942760=>bpf-next
branch
from
efe7c5f to
d773380
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
474f6ed to
44c3a1d
Compare
Venkat reported a compilation error for BPF selftests on PowerPC [0].
The crux of the error is the following message:
In file included from progs/arena_spin_lock.c:7:
/root/bpf-next/tools/testing/selftests/bpf/bpf_arena_spin_lock.h:122:8:
error: member reference base type '__attribute__((address_space(1)))
u32' (aka '__attribute__((address_space(1))) unsigned int') is not a
structure or union
122 | old = atomic_read(&lock->val);
This is because PowerPC overrides the qspinlock type changing the
lock->val member's type from atomic_t to u32.
To remedy this, import the asm-generic version in the arena spin lock
header, name it __qspinlock (since it's aliased to arena_spinlock_t, the
actual name hardly matters), and adjust the selftest to not depend on
the type in vmlinux.h.
[0]: https://lore.kernel.org/bpf/[email protected]
Fixes: 0201027 ("selftests/bpf: Introduce arena spin lock")
Reported-by: Venkat Rao Bagalkote <[email protected]>
Signed-off-by: Kumar Kartikeya Dwivedi <[email protected]>
Tested-by: Venkat Rao Bagalkote <[email protected]>
|
Upstream branch: be741c7 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/942760=>bpf-next
branch
from
d773380 to
b751291
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
44c3a1d to
720c696
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=942760 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/bpf: Fix arena_spin_lock compilation on PowerPC
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=942760