Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the URL regexes matching urls starting with a vulgar www. #1185

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Update the URL regexes matching urls starting with a vulgar www. #1185

merged 3 commits into from
Oct 23, 2024

Conversation

lfoppiano
Copy link
Collaborator

@lfoppiano lfoppiano commented Oct 20, 2024 •
edited
Loading

We added a new regex that provide an alternative matching for the URLs (I did not dear to modify the body of the existing one)

@lfoppiano lfoppiano mentioned this pull request Oct 20, 2024
Closed
@coveralls
Copy link

coveralls commented Oct 20, 2024 •
edited
Loading

Coverage Status

coverage: 40.755% (+0.003%) from 40.752%
when pulling 40a1742 on update-regexes-urls
into d2f0cdc on master.

@kermitt2
Copy link
Owner

It looks good to me !

@lfoppiano lfoppiano marked this pull request as ready for review October 21, 2024 15:40
@lfoppiano lfoppiano added this to the 0.8.2 milestone Oct 21, 2024
@lfoppiano lfoppiano merged commit be44579 into master Oct 23, 2024
10 checks passed
@lfoppiano lfoppiano deleted the update-regexes-urls branch October 23, 2024 08:07
@lfoppiano lfoppiano linked an issue Oct 31, 2024 that may be closed by this pull request
some URLs are not extracted in DAS #1184
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.2
Development

Successfully merging this pull request may close these issues.

some URLs are not extracted in DAS
3 participants
@lfoppiano @coveralls @kermitt2