Fix #108 For KB concepts the given "valueName" of statements should be the english label instead of the wikipedia page title #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…should be the english label instead of the wikipedia page title
|
Many thanks for the PR ! I added an additional lmdb for the labels introduced by wikidata for the supported languages in #142. This is cleaner than adding a fake property P0 and is useful for other improvements. The rest is as your PR, which was very helpful to solve the problem of #108 and save time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Patrice
As you recommend for the moment the proposed modification is done in entity fishing (not in grisp) creating a fake property P0 / label as new statement