deps: switch to modernc.org/sqlite for pure go builds

Dockerfile.local

@@ -1,13 +1,12 @@
 FROM golang:alpine as builder
-RUN apk add --no-cache gcc g++
 
 RUN mkdir /build
 RUN mkdir /dist
 WORKDIR build
 COPY go.mod go.mod
 RUN go mod download
 COPY . .
-RUN go build -ldflags "-extldflags -static -X main.VERSION=${VERSION##*/v}" -o /dist/authn
+RUN CGO_ENABLED=0 go build -ldflags "-extldflags -static -X main.VERSION=${VERSION##*/v}" -o /dist/authn
 
 FROM alpine
 RUN apk add --no-cache ca-certificates

Makefile

@@ -34,6 +34,15 @@ test: init
 	  TEST_POSTGRES_URL=postgres://$(DB_USERNAME):$(DB_PASSWORD)@127.0.0.1:8703/postgres?sslmode=disable \
 	  go test -race ./...
 
+.PHONY: test-nocgo
+test-nocgo: init
+	docker-compose up -d redis mysql postgres
+	TEST_REDIS_URL=redis://127.0.0.1:8701/12 \
+	  TEST_MYSQL_URL=mysql://[email protected]:8702/authnservertest \
+	  TEST_POSTGRES_URL=postgres://$(DB_USERNAME):$(DB_PASSWORD)@127.0.0.1:8703/postgres?sslmode=disable \
+	  CGO_ENABLED=0 \
+	  go test ./...
+
 # Run benchmarks
 .PHONY: benchmarks
 benchmarks:

app/data/data.go

@@ -12,7 +12,7 @@ import (
 	"github.com/keratin/authn-server/app/data/mysql"
 	"github.com/keratin/authn-server/app/data/postgres"
 	"github.com/keratin/authn-server/app/data/sqlite3"
-	sq3 "github.com/mattn/go-sqlite3"
+	sq3 "modernc.org/sqlite"
 )
 
 func NewDB(url *url.URL) (*sqlx.DB, error) {
@@ -61,8 +61,8 @@ func MigrateDB(url *url.URL) error {
 
 func IsUniquenessError(err error) bool {
 	switch i := err.(type) {
-	case sq3.Error:
-		return i.ExtendedCode == sq3.ErrConstraintUnique
+	case *sq3.Error:
+		return i.Code() == 2067 // SQLITE_CONSTRAINT_UNIQUE
 	case *my.MySQLError:
 		return i.Number == 1062
 	case *pq.Error:

app/data/sqlite3/blob_store.go

@@ -6,8 +6,8 @@ import (
 
 	"github.com/jmoiron/sqlx"
 	"github.com/keratin/authn-server/ops"
-	sq3 "github.com/mattn/go-sqlite3"
 	"github.com/pkg/errors"
+	sq3 "modernc.org/sqlite"
 )
 
 var placeholder = "generating"
@@ -43,7 +43,7 @@ func (s *BlobStore) Read(name string) ([]byte, error) {
 
 func (s *BlobStore) WriteNX(name string, blob []byte) (bool, error) {
 	_, err := s.DB.Exec("INSERT INTO blobs (name, blob, expires_at) VALUES (?, ?, ?)", name, blob, time.Now().Add(s.TTL))
-	if i, ok := err.(sq3.Error); ok && i.ExtendedCode == sq3.ErrConstraintUnique {
+	if i, ok := err.(*sq3.Error); ok && i.Code() == 2067 {
 		return false, nil
 	}
 	if err != nil {

app/data/sqlite3/db.go

@@ -1,24 +1,31 @@
 package sqlite3
 
 import (
+	"database/sql"
 	"fmt"
 	"strings"
 
 	"github.com/jmoiron/sqlx"
+	"modernc.org/sqlite"
+
 	// load sqlite3 library with side effects
-	_ "github.com/mattn/go-sqlite3"
+	_ "modernc.org/sqlite"
 )
 
+func init() {
+	sql.Register("sqlite3", &sqlite.Driver{})
+}
+
 func NewDB(env string) (*sqlx.DB, error) {
-	// https://github.com/mattn/go-sqlite3/issues/274#issuecomment-232942571
+	// https://modernc.org/sqlite/issues/274#issuecomment-232942571
 	// enable a busy timeout for concurrent load. keep it short. the busy timeout can be harmful
 	// under sustained load, but helpful during short bursts.
-	
-	// this block used to keep backward compatibility 
+
+	// this block used to keep backward compatibility
 	if !strings.Contains(env, ".") {
-		env = "./"+ env +".db"
+		env = "./" + env + ".db"
 	}
-	
+
 	return sqlx.Connect("sqlite3", fmt.Sprintf("%v?cache=shared&_busy_timeout=200", env))
 }
 

app/data/sqlite3/migrations.go

@@ -1,10 +1,11 @@
 package sqlite3
 
 import (
+	"errors"
 	"strings"
 
 	"github.com/jmoiron/sqlx"
-	"github.com/mattn/go-sqlite3"
+	"modernc.org/sqlite"
 )
 
 // MigrateDB is committed to doing the work necessary to converge the database
@@ -29,8 +30,9 @@ func MigrateDB(db *sqlx.DB) error {
 }
 
 func isDuplicateError(e error) bool {
-	sqliteError, ok := e.(sqlite3.Error)
-	return ok && sqliteError.Code == 1 && strings.Contains(sqliteError.Error(), "duplicate column name")
+	var sqliteError *sqlite.Error
+	ok := errors.As(e, &sqliteError)
+	return ok && sqliteError.Code() == 1 && strings.Contains(sqliteError.Error(), "duplicate column name")
 }
 
 func createAccounts(db *sqlx.DB) error {

app/services/account_creator_test.go

@@ -23,7 +23,8 @@ func TestAccountCreatorSuccess(t *testing.T) {
 		{app.Config{UsernameIsEmail: true, UsernameDomains: []string{"rightdomain.com"}}, "[email protected]", "PASSword"},
 	}
 
-	for _, tc := range testCases {
+	for i := range testCases {
+		tc := testCases[i] // avoid implicit capture
 		acc, err := services.AccountCreator(store, &tc.config, tc.username, tc.password)
 		require.NoError(t, err)
 		assert.NotEqual(t, 0, acc.ID)
@@ -60,7 +61,8 @@ func TestAccountCreatorFailure(t *testing.T) {
 		{app.Config{UsernameIsEmail: true}, "[email protected]", "[email protected]", services.FieldErrors{{"password", "INSECURE"}}},
 	}
 
-	for _, tc := range testCases {
+	for i := range testCases {
+		tc := testCases[i] // avoid implicit capture
 		t.Run(tc.username, func(t *testing.T) {
 			acc, err := services.AccountCreator(store, &tc.config, tc.username, tc.password)
 			if assert.Equal(t, tc.errors, err) {

go.mod

@@ -18,7 +18,7 @@ require (
 	github.com/jmoiron/sqlx v0.0.0-20170430194603-d9bd385d68c0
 	github.com/joho/godotenv v1.2.0
 	github.com/lib/pq v1.10.0
-	github.com/mattn/go-sqlite3 v1.6.0
+	github.com/mattn/go-sqlite3 v1.14.18 // indirect
 	github.com/pkg/errors v0.9.1
 	github.com/prometheus/client_golang v1.11.1
 	github.com/sirupsen/logrus v1.6.0
@@ -28,4 +28,5 @@ require (
 	golang.org/x/crypto v0.1.0
 	golang.org/x/oauth2 v0.0.0-20190226205417-e64efc72b421
 	gopkg.in/square/go-jose.v2 v2.3.1
+	modernc.org/sqlite v1.27.0
 )