Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pip build #779

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −8
Open

Fix pip build #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d3bb64
docs: update CONTRIBUTING.md with new name tf-keras
jonas-eschle May 24, 2024
7bd7b3d
fix: python build ignore experimental due to circular refs
jonas-eschle May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ development environment and run the unit tests. This is covered in the section
### Step 3. Create a pull request

Once the change is ready, open a pull request from your branch in your fork to
the master branch in [keras-team/keras](https://github.com/keras-team/keras).
the master branch in [keras-team/tf-keras](https://github.com/keras-team/tf-keras).

### Step 4. Sign the Contributor License Agreement

Expand Down Expand Up @@ -149,8 +149,8 @@ as a dependency, we need to uninstall `keras-nightly` so that tests will run
against TF-Keras code in the local workspace.

```shell
git clone https://github.com/YOUR_GITHUB_USERNAME/keras.git
cd keras
git clone https://github.com/YOUR_GITHUB_USERNAME/tf-keras.git
cd tf-keras
pip install -r requirements.txt
pip uninstall keras-nightly
```
Expand Down Expand Up @@ -220,14 +220,14 @@ We use [Bazel](https://bazel.build/) to build and run the tests.

### Run a test file

For example, to run the tests in `keras/engine/base_layer_test.py`,
For example, to run the tests in `tf_keras/engine/base_layer_test.py`,
we can run the following command at the root directory of the repo.

```shell
bazel test keras/engine:base_layer_test
bazel test tf_keras/engine:base_layer_test
```

`keras/engine` is the relative path to the directory containing the `BUILD` file
`tf_keras/engine` is the relative path to the directory containing the `BUILD` file
defining the test. `base_layer_test` is the test target name defined with
`tf_py_test` in the `BUILD` file.

Expand All @@ -239,7 +239,7 @@ can use the following command to run all the tests in `activations_test.py`,
whose names contain `test_serialization`.

```
bazel test keras:activations_test --test_filter=*test_serialization*
bazel test tf_keras:activations_test --test_filter=*test_serialization*
```

### Run all tests
Expand Down Expand Up @@ -267,7 +267,7 @@ command above.
However, it may slow down the tests for not running in parallel
and may cause the test to timeout.

## Contributing to TF-Keras applications
## Contributing to TF-tf_keras applications

Contributions to the
[pre-trained application library](https://keras.io/api/applications/) are
Expand Down
2 changes: 2 additions & 0 deletions tf_keras/tools/pip_package/create_pip_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
PIP_EXCLUDED_DIRS = frozenset(
[
"tf_keras/benchmarks",
"tf_keras/layers/experimental", # cannot build currently, circular refs
"tf_keras/tests",
]
)
Expand All @@ -45,6 +46,7 @@
EXCLUDED_INIT_FILE_DIRECTORIES = frozenset(
[
"tf_keras/benchmarks",
"tf_keras/layers/experimental",
"tf_keras/tools",
]
)
Expand Down
Loading