Skip to content

mlx - test updates and signbit implementation #21180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 18, 2025

Conversation

acsweet
Copy link

@acsweet acsweet commented Apr 17, 2025

This addresses #19571

Include the following:

  • more tests updated as needed by mlx
  • signbit implementation
  • align left_shift, right_shift, and top_k to match other backends
    • top_k default to sorted adds a bit of overhead, could set this to False and adjust tests
  • convert_to_numpy more correct handling of bfloat16
  • added placeholders for some unimplemented ops

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 20.68966% with 46 lines in your changes missing coverage. Please review.

Please upload report for BASE (mlx@65f75bb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
keras/src/backend/mlx/numpy.py 5.12% 37 Missing ⚠️
keras/src/backend/mlx/math.py 0.00% 5 Missing ⚠️
keras/src/backend/mlx/core.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             mlx   #21180   +/-   ##
======================================
  Coverage       ?   76.03%           
======================================
  Files          ?      577           
  Lines          ?    57762           
  Branches       ?     8960           
======================================
  Hits           ?    43922           
  Misses         ?    11806           
  Partials       ?     2034           
Flag Coverage Δ
keras 75.86% <20.68%> (?)
keras-jax 60.90% <20.68%> (?)
keras-numpy 56.29% <20.68%> (?)
keras-tensorflow 61.19% <20.68%> (?)
keras-torch 60.15% <10.34%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 18, 2025
@fchollet fchollet merged commit fe4ba17 into keras-team:mlx Apr 18, 2025
5 of 8 checks passed
@gbaned gbaned added this to PR Queue Apr 25, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue Apr 25, 2025
@acsweet acsweet deleted the mlx-updates-merged branch May 12, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run ready to pull Ready to be merged into the codebase size:M
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

4 participants