Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove torchvision dep and simplify resize and rgb_to_grayscale in torch backend #20868

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

james77777778
Copy link
Contributor

We can simplify the logic of resize and rgb_to_grayscale and remove the dep of torchvision

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.24%. Comparing base (c04cf9d) to head (4ee27b6).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/torch/image.py 90.00% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20868   +/-   ##
=======================================
  Coverage   82.24%   82.24%           
=======================================
  Files         561      561           
  Lines       52633    52642    +9     
  Branches     8137     8134    -3     
=======================================
+ Hits        43288    43297    +9     
- Misses       7340     7341    +1     
+ Partials     2005     2004    -1     
Flag Coverage Δ
keras 82.05% <90.00%> (+<0.01%) ⬆️
keras-jax 64.21% <8.00%> (-0.01%) ⬇️
keras-numpy 59.02% <8.00%> (-0.01%) ⬇️
keras-openvino 32.51% <0.00%> (-0.01%) ⬇️
keras-tensorflow 64.84% <8.00%> (-0.01%) ⬇️
keras-torch 64.28% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Feb 7, 2025
@fchollet fchollet merged commit b2d5b88 into keras-team:master Feb 7, 2025
7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Feb 7, 2025
@james77777778 james77777778 deleted the remove-torchvision-dep branch February 8, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants