Add numpy trainer #633
Merged
Add numpy trainer #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
approved these changes
Jul 28, 2023
| return_dict=False, | ||
| **kwargs, | ||
| ): | ||
| # TODO: respect compiled trainable state |
There was a problem hiding this comment.
For reference, this is something that tf.keras always does (use the trainable values of layers as they existed at the time compile() was called), which may not always be verified in some cases in Keras Core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to keras-team/keras#18442
This PR mainly implements the numpy trainer with references to torch and jax.
Two tests have been added to improve the test coverage of the numpy trainer:
test_steps_per_execution_steps_count_without_trainingtest_on_batch_methods_without_trainingAdditionally, there is a bug that some
steps_per_executionare missing inTFEpochIteratordeclaration inkeras_core/backend/tensorflow/trainer.py. It has been catched by new tests and fixed by this PR.