Skip to content

Commit

Permalink
Increase-test-coverage for keras_tensor
Browse files Browse the repository at this point in the history
  • Loading branch information
Faisal-Alsrheed committed Sep 22, 2023
1 parent 92f36b3 commit 7d27055
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 30 deletions.
24 changes: 0 additions & 24 deletions keras_core/backend/common/keras_tensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,49 +166,25 @@ def __rmatmul__(self, other):
return ops.Matmul().symbolic_call(other, self)

def __div__(self, other):
print("Inside __div__ method!")
from keras_core import ops

return ops.Divide().symbolic_call(self, other)

def __rdiv__(self, other):
print("Inside __rdiv__ method!")
from keras_core import ops

return ops.Divide().symbolic_call(other, self)

def __truediv__(self, other):
print("Inside __truediv__ method!")
from keras_core import ops

return ops.TrueDivide().symbolic_call(self, other)

def __rtruediv__(self, other):
print("Inside __rtruediv__ method!")
from keras_core import ops

return ops.TrueDivide().symbolic_call(other, self)

# def __div__(self, other):
# from keras_core import ops

# return ops.Divide().symbolic_call(self, other)

# def __rdiv__(self, other):
# from keras_core import ops

# return ops.Divide().symbolic_call(other, self)

# def __truediv__(self, other):
# from keras_core import ops

# return ops.TrueDivide().symbolic_call(self, other)

# def __rtruediv__(self, other):
# from keras_core import ops

# return ops.TrueDivide().symbolic_call(other, self)

def __neg__(self):
from keras_core import ops

Expand Down
12 changes: 6 additions & 6 deletions keras_core/backend/common/keras_tensor_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -362,24 +362,24 @@ def test_rtruediv_method(self, mock_symbolic_call):
mock_symbolic_call.assert_called_once_with(y, x)
self.assertEqual(result, mock_tensor)

# #TODO: FAILED Expected 'symbolic_call' to be called once but wasn't.
# TODO: FAILED Expected 'symbolic_call' to be called once but wasn't.
# @patch("keras_core.ops.Divide.symbolic_call")
# def test_div_method(self, mock_symbolic_call):
# mock_tensor = Mock()
# mock_symbolic_call.return_value = mock_tensor
# x = keras_tensor.KerasTensor(shape=(1,), dtype="float32")
# y = keras_tensor.KerasTensor(shape=(1,), dtype="float32")
# x = keras_tensor.KerasTensor(shape=(3, 4), dtype="float32")
# y = keras_tensor.KerasTensor(shape=(3, 4), dtype="float32")
# result = x / y
# mock_symbolic_call.assert_called_once_with(x, y)
# self.assertEqual(result, mock_tensor)

# #TODO: FAILED Expected 'symbolic_call' to be called once but wasn't.
# TODO: FAILED Expected 'symbolic_call' to be called once but wasn't.
# @patch("keras_core.ops.Divide.symbolic_call")
# def test_rdiv_method(self, mock_symbolic_call):
# mock_tensor = Mock()
# mock_symbolic_call.return_value = mock_tensor
# x = keras_tensor.KerasTensor(shape=(1,), dtype="float32")
# y = keras_tensor.KerasTensor(shape=(1,), dtype="float32")
# x = keras_tensor.KerasTensor(shape=(3, 4), dtype="float32")
# y = keras_tensor.KerasTensor(shape=(3, 4), dtype="float32")
# result = y / x
# mock_symbolic_call.assert_called_once_with(y, x)
# self.assertEqual(result, mock_tensor)

0 comments on commit 7d27055

Please sign in to comment.