Skip to content
This repository has been archived by the owner on Nov 3, 2022. It is now read-only.

Added Inverse Square Root Linear Unit (ISRLU) activation layer #455

Closed
wants to merge 6 commits into from
Closed

Added Inverse Square Root Linear Unit (ISRLU) activation layer #455

wants to merge 6 commits into from

Conversation

SriRangaTarun
Copy link
Contributor

- What I did
See above. Here's the axrXiv paper.

- How I did it

- How you can verify it
I added unit tests.


This pull request fixes #issue_number_here

Copy link
Contributor

@RaphaelMeudec RaphaelMeudec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this new PR! The code is clean, just have a small question on the implementation. Good job!

def identity(x):
return x

return K.switch(K.less(x, K.zeros_like(x)), inverse_square(x), identity(x))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why introducing the identity function and not just pass x as argument

self.build = True

def call(self, x):
def inverse_square(x):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name inverse_square might not be appropriate as the function does not exactly return 1/x^2

@SriRangaTarun
Copy link
Contributor Author

SriRangaTarun commented Feb 14, 2019

@RaphaelMeudec Please note that I am closing this pull request and opening an alias with all the changes you specified. Thanks for reviewing !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants