Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove cluster admin ClusterRoleBinding and ServiceAccount #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Remove cluster admin ClusterRoleBinding and ServiceAccount #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions helm/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,3 @@ app.kubernetes.io/name: {{ include "keptn-service.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
{{- end }}

{{/*
Create the name of the service account to use
*/}}
{{- define "keptn-service.serviceAccountName" -}}
{{- if .Values.serviceAccount.create }}
{{- default (include "keptn-service.fullname" .) .Values.serviceAccount.name }}
{{- else }}
{{- default "default" .Values.serviceAccount.name }}
{{- end }}
{{- end }}
2 changes: 1 addition & 1 deletion helm/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
serviceAccountName: {{ include "keptn-service.serviceAccountName" . }}
serviceAccountName: {{ .Values.keptnservice.serviceAccountName }}
securityContext:
{{- toYaml .Values.podSecurityContext | nindent 8 }}
containers:
Expand Down
30 changes: 0 additions & 30 deletions helm/templates/serviceaccount.yaml
View file
Open in desktop

This file was deleted.

6 changes: 1 addition & 5 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ keptnservice:
tag: "dev" # Container Tag
service:
enabled: true # Creates a Kubernetes Service for the locust-service
serviceAccountName: default

distributor:
stageFilter: "" # Sets the stage this helm service belongs to
Expand All @@ -25,11 +26,6 @@ remoteControlPlane:

imagePullSecrets: [] # Secrets to use for container registry credentials

serviceAccount:
create: true # Enables the service account creation
annotations: {} # Annotations to add to the service account
name: "" # The name of the service account to use.

podAnnotations: {} # Annotations to add to the created pods

podSecurityContext: {} # Set the pod security context (e.g. fsGroups)
Expand Down