Added additional error trap, #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pcjeffmac this does not fix the issue If I have 50 SLIs that I want to evaluate and 1 of them does not return a value, the evaluation will never finish in this case, which is not desired behaviour. The SLO for that particular metric will fail and will affect the total build score anyway. A check for |
|
Moved logical check for "[]" returned condition. |
|
changed logical check, will resubmit PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the result from Keptn does not return a proper result from the API.
It will contain "[]" which can also be the case when waiting for a result.
Added additional trap if the keptn result returns a bad result from the API.
The returned result will contain "troubleshooting". This is then used to kick out of the waiting for result function.
Then set a message that the result was improper and set result to failure.
This is in reference to issue #26
This fix should work with keptn 0.8.x