-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Jest 28 #239
base: master
Are you sure you want to change the base?
Conversation
No, Jest 27 supported both strings and an object: type TransformedSource =
| {code: string; map?: RawSourceMap | string | null}
| string; While Jest 28 only dropped support for the raw string: type TransformedSource = {
code: string;
map?: RawSourceMap | string | null;
}; Therefore this isn't a breaking change for Jest 27 users. @keplersj I hope to see this merged soon. |
Remove jest-raw-loader dependency and add own loader based on keplersj/jest-raw-loader#239 for compatibility with Jest 28.
Btw, I currently solve it like so...
in in
|
Indeed it's easier to just drop the dependency |
It does not work with jest 28 until keplersj/jest-raw-loader#239. Signed-off-by: Max <[email protected]>
Remove jest-raw-loader dependency and add own loader based on keplersj/jest-raw-loader#239 for compatibility with Jest 28.
Remove jest-raw-loader dependency and add own loader based on keplersj/jest-raw-loader#239 for compatibility with Jest 28.
Without this merged people will be abandoning this package and just do the copy/paste fix in their project: |
perhaps merge and release this with 2.0.0 version already? |
this also works:
refs: |
Merged this to my fork: I plan to release it in npm. stay tuned. |
Published as |
@glensc I cannot comment onto your archived repo, maybe you could just precise the workaround to still keep using your realase: #430 (comment) Thanks again for your work, I used it for years, and still! |
@sneko: unarchived. send a PR? |
Breaks compatibility with Jest < 27, most probably (Didn't test that).