Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] experimental support for ARROW:extension:point #2716

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

igorDykhta
Copy link
Collaborator

  • adds support for ARROW:extension:name EXTENSION_NAME.POINT position columns in Point, Line, Arc, Text layers.
  • can pick geoarrow point column as source for Heatmap layer.
  • interleaved xy geoarrow point vector is passed directly as a position data attribute for rendering.
  • separate lon / lat columns are converted to geoarrow point vectors (only when source file is an .arrow file).
  • this PR doesn't affect existing loading and support of non-geo columns.

Known issues:

  • text layer supplied with ARROW:extension:point column can only render string arrow columns (no values offsets).
  • figure out how to store an Arrow table in Arrow Data containers, and to update it properly with progressive loading.

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for keplergl2 ready!

Name Link
🔨 Latest commit 898cea7
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/6719f24b58ebcd0008589962
😎 Deploy Preview https://deploy-preview-2716--keplergl2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
…n we deal with arrow tables

Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta igorDykhta marked this pull request as ready for review October 24, 2024 07:49
@igorDykhta igorDykhta changed the base branch from master to duckdb-plugin October 25, 2024 16:12
@igorDykhta igorDykhta changed the base branch from duckdb-plugin to master October 25, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant