Fix bug where single row slider is still generating extra row markup #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed options check to ensure extra row markup only gets created where there is more than 1 row. Added extra class to the row element to make it’s purpose less ambiguous.
|
This has fixed the bug I've been trying to catch for whole three days, thanks! |
|
I just don't understand how this component can be that much broken for 3 years |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed options check to ensure extra row markup only gets created where there is more than 1 row.
Added extra class to the row element to make its purpose less ambiguous.
For several years now, I've noticed that a single row slider still generates this extra markup. Since the markup is just an empty div, its purpose is not exactly clear and thus has tripped up several developers I've spoken with.
Since the default row value is 1, this seems like a simple and appropriate change to make the option work as expected and have the resulting markup be more clear for the developer.