Messages_prop_is_corrected (#151)

* Messages prop is corrected * Add explicit test for passing messages
kenshoo · May 16, 2019 · 139cc3b · 139cc3b
1 parent 1148417
commit 139cc3b
Show file tree

Hide file tree

Showing 6 changed files with 69 additions and 6 deletions.
diff --git a/src/components/with_search.js b/src/components/with_search.js
@@ -12,7 +12,7 @@ const withSearch = WrappedComponent => ({
 }) => {
   const SearchRenderer = searchRenderer;
   return (
-    <WrappedComponent {...others}>
+    <WrappedComponent {...others} messages={messages}>
       {showSearch && (
         <SearchRenderer
           onChange={filterItems}

diff --git a/tests/components/__snapshots__/destination_list.spec.js.snap b/tests/components/__snapshots__/destination_list.spec.js.snap
@@ -6,7 +6,13 @@ exports[`DestinationList Case disabled search with destination list 1`] = `
   height={400}
   itemHeight={40}
   listRenderer={[Function]}
-  messages={Object {}}
+  messages={
+    Object {
+      "messages": Object {
+        "searchPlaceholder": "Search",
+      },
+    }
+  }
   noItemsRenderer={[Function]}
   selectedIds={Array []}
   selectedItemRenderer={[Function]}
@@ -21,7 +27,13 @@ exports[`DestinationList Case include search with destination list 1`] = `
   height={400}
   itemHeight={40}
   listRenderer={[Function]}
-  messages={Object {}}
+  messages={
+    Object {
+      "messages": Object {
+        "searchPlaceholder": "Search",
+      },
+    }
+  }
   noItemsRenderer={[Function]}
   selectedIds={Array []}
   selectedItemRenderer={[Function]}

diff --git a/tests/components/__snapshots__/multi_select.spec.js.snap b/tests/components/__snapshots__/multi_select.spec.js.snap
@@ -4530,7 +4530,14 @@ Object {
   "itemHeight": 40,
   "itemRenderer": [Function],
   "listRenderer": [Function],
-  "messages": Object {},
+  "messages": Object {
+    "clearAllMessage": "Uncheck all",
+    "noItemsMessage": "No entries available...",
+    "noneSelectedMessage": "Nothing",
+    "searchPlaceholder": "Find...",
+    "selectAllMessage": "Check all",
+    "selectedMessage": "Checked",
+  },
   "noItemsRenderer": [Function],
   "selectAllHeight": undefined,
   "selectAllItems": undefined,

diff --git a/tests/components/__snapshots__/source_list.spec.js.snap b/tests/components/__snapshots__/source_list.spec.js.snap
@@ -427,7 +427,16 @@ exports[`SourceList passed source_list wrapped up to HOC withSearch 1`] = `
   itemHeight={10}
   itemRenderer={[MockFunction mockedComponent]}
   listRenderer={[Function]}
-  messages={Object {}}
+  messages={
+    Object {
+      "clearAllMessage": "Uncheck all",
+      "noItemsMessage": "No entries available...",
+      "noneSelectedMessage": "Nothing",
+      "searchPlaceholder": "Find...",
+      "selectAllMessage": "Check all",
+      "selectedMessage": "Checked",
+    }
+  }
   noItemsRenderer={[Function]}
   selectAllHeight={60}
   selectAllItems={[MockFunction selectAllItems]}

diff --git a/tests/components/__snapshots__/with_search.spec.js.snap b/tests/components/__snapshots__/with_search.spec.js.snap
@@ -10,6 +10,11 @@ exports[`With search Case custom search component 1`] = `
       },
     ]
   }
+  messages={
+    Object {
+      "searchPlaceholder": "Search",
+    }
+  }
 >
   <UserSearch
     onChange={[MockFunction]}
@@ -35,6 +40,11 @@ exports[`With search Case default search component 1`] = `
       },
     ]
   }
+  messages={
+    Object {
+      "searchPlaceholder": "Search",
+    }
+  }
 >
   <Search
     onChange={[MockFunction]}
@@ -50,4 +60,12 @@ exports[`With search Case default search component 1`] = `
 </CustomComponent>
 `;
 
-exports[`With search Case not search component 1`] = `<CustomComponent />`;
+exports[`With search Case not search component 1`] = `
+<CustomComponent
+  messages={
+    Object {
+      "searchPlaceholder": "Search",
+    }
+  }
+/>
+`;
diff --git a/tests/components/with_search.spec.js b/tests/components/with_search.spec.js
@@ -1,4 +1,5 @@
 import React from "react";
+import { mount } from "enzyme";
 import ShallowRenderer from "react-test-renderer/shallow";
 import withSearch from "../../src/components/with_search.js";
 
@@ -60,4 +61,20 @@ describe("With search", () => {
     );
     expect(component).toMatchSnapshot();
   });
+
+  test("Case messages are passed ok", () => {
+    const filterItems = jest.fn();
+    const component = mount(
+      <ListComponent
+        showSearch={false}
+        searchRenderer={UserSearch}
+        searchIcon={<img src="custom_icon" alt="" />}
+        searchValue="11"
+        messages={messages}
+        filterItems={filterItems}
+      />
+    );
+    const listComponent = component.find(ListComponent);
+    expect(listComponent.props().messages).toEqual(messages);
+  });
 });