Compatibility with entirety of Genius; Song Search based on Title + Artist #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuichitlo Sorry for the super late getting back! It seems I took too long a break from this project. I have had a quick skim through your code. It seems you commented out a few portions of code and moved stuff from my By the way your changes seem to have broken the build so I would not be able to merge unless the build is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to accommodate Genius' growing database and searches outside of rap and rock, everything has been generalized to http://genius.com and searches can be refined by the combination of title and artist information. This works much better as you filter out songs of the same title within a genre and are more likely to get a correct result.
I also thought renaming the project would make sense! Thanks for creating this API for working with Genius!