Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Dockerization #24

Merged
merged 3 commits into from
Oct 30, 2016
Merged

Some Dockerization #24

merged 3 commits into from
Oct 30, 2016

Conversation

dschaper
Copy link
Contributor

The existing Dockerfile could use a little bit of Dockerization. This still does not solve the issue with postgresql not working with npm run start on build, but it's a start. You can run bash into the last image, start postgres and psql -U postgres works. But.... This really should be a composed docker. NodeJS in one container, nginx in another container and postgresql in a 3rd. Working on that part, and possibly moving to another not-as-heavy base image for everything to run in.

Convert Dockerfile to more along Docker guidelines
@kengz
Copy link
Owner

kengz commented Oct 30, 2016

Thanks for the PR! Yeah the Dockerfile is damn out of date compared to the current master. Waiting for the cgkb branch to be done to get back into Docker again.

@kengz kengz mentioned this pull request Oct 30, 2016
@dschaper
Copy link
Contributor Author

It would be nice to have, hubot just doesn't cut it anymore. Look forward to getting AIVA up and running!

Update bin/start to cover postgres instead of mysql.
@kengz
Copy link
Owner

kengz commented Oct 30, 2016

Awesome. Is that all the changes?

@dschaper
Copy link
Contributor Author

Yes, for now, still not fully functional, but it's a good framework and cuts the full image down to 700MB for now with Ubuntu16.04

@dschaper
Copy link
Contributor Author

Looking at composing a few containers but doing it with minimal need to change the node or anything on your end of development.

@kengz kengz merged commit 66affaa into kengz:master Oct 30, 2016
@dschaper
Copy link
Contributor Author

https://hub.docker.com/r/zabbix/zabbix-server-pgsql/ May be of interest in the scheme, noting their way of creating the psql databases at build time. Not sure if that would conflict with non-Docker installs though, can sequalize handle an existing database and username if provided in the db.json?

@kengz
Copy link
Owner

kengz commented Oct 31, 2016

yep. In face it requires the database to exist in the first place (I use some bash for that) before running sequelize.

Just opened up a new issue for this, let's move to #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants