Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(requirements): add hashing step #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build(requirements): add hashing step #14

wants to merge 1 commit into from

Conversation

skezo
Copy link
Contributor

@skezo skezo commented Nov 5, 2022

Adding hashing step and update readme.

kencanak
kencanak requested changes Nov 5, 2022
View reviewed changes
Copy link
Owner

@kencanak kencanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, requirements.txt will be auto generated. Should we put it in gitignore then? @skezo

@skezo
Copy link
Contributor Author

skezo commented Nov 5, 2022 •
edited
Loading

requirements.txt will be auto generated.

Yes. I think pip-compile --generate-hashes should be manually run when the requirements.in file is updated.

Should we put it in gitignore then?

I don't think it should be added to gitignore. see above

@skezo skezo requested a review from kencanak November 7, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kencanak kencanak Awaiting requested review from kencanak

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skezo @kencanak