Skip to content

remove package and import declaration #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: pioasm-go-output
Choose a base branch
from
Open

remove package and import declaration #1

wants to merge 6 commits into from

Conversation

soypat
Copy link

@soypat soypat commented Oct 28, 2023

@soypat
Copy link
Author

soypat commented Oct 28, 2023

Part of tinygo-org/tinygo#1983

@soypat
Copy link
Author

soypat commented Oct 28, 2023

I've renamed cfg.SetSideSet which seemed to be confusing to me as to how to interpret to a clearer cfg.SetSidesetParams. I understand this differs from upstream but it would provide clearer name of what exactly is happening in that step. SetSideSet really just sounds like a method that sets the Sideset pin base.

graugans
graugans reviewed Nov 1, 2023
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graugans graugans graugans left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soypat @graugans