[Feature] Order - get capture, refund, cancel, update and delete transaction #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+54
to
+56
| payload = data&.to_json | ||
|
|
||
| @http_client.post(url: @config.api_base_url + uri, data: data.to_json, headers: headers, | ||
| timeout: request_options.connection_timeout) | ||
| @http_client.post(url: @config.api_base_url + uri, data: payload, headers: headers, timeout: request_options.connection_timeout) |
There was a problem hiding this comment.
[q] Aqui vc só extraiu o data.to_json para uma variável? Por que foi necessário colocar o &?
There was a problem hiding this comment.
o é em Ruby é uma validação, não um endereço!
There was a problem hiding this comment.
é um bug @andreagostinho-meli, se eu fizer data.to_json independente se data tiver valor ou nao ele vai tentar fazer o to_json e irá enviar para o payload um valor NULL.
com o & se data estiver nulo ele nao tenta fazer o to_json, é quase um if ternário
danielen-meli
approved these changes
Feb 6, 2025
VickieAranha
approved these changes
Feb 7, 2025
renanneri01
approved these changes
Feb 7, 2025
andreagostinho-meli
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.