Skip to content

Minor fixes

Minor fixes #74

GitHub Actions / Run clippy (ubuntu-latest, all features) succeeded Aug 6, 2024 in 1s

Run clippy (ubuntu-latest, all features)

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.82.0-nightly (e57f3090a 2024-08-05)
  • cargo 1.82.0-nightly (fa6465836 2024-08-02)
  • clippy 0.1.82 (e57f309 2024-08-05)

Annotations

Check warning on line 893 in frontend/desktop/src/debug_views/fs.rs

See this annotation in the file changed.

@github-actions github-actions / Run clippy (ubuntu-latest, all features)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> frontend/desktop/src/debug_views/fs.rs:889:33
    |
889 |                           ui.text(&format!(
    |  _________________________________^
890 | |                             "{} \u{f061} {}",
891 | |                             export.source,
892 | |                             export.destination.display()
893 | |                         ));
    | |_________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
note: the lint level is defined here
   --> frontend/desktop/src/main.rs:14:9
    |
14  | #![warn(clippy::all)]
    |         ^^^^^^^^^^^
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` implied by `#[warn(clippy::all)]`
help: change this to
    |
889 ~                         ui.text(format!(
890 +                             "{} \u{f061} {}",
891 +                             export.source,
892 +                             export.destination.display()
893 ~                         ));
    |

Check warning on line 611 in frontend/desktop/src/ui/window.rs

See this annotation in the file changed.

@github-actions github-actions / Run clippy (ubuntu-latest, all features)

variable does not need to be mutable

warning: variable does not need to be mutable
   --> frontend/desktop/src/ui/window.rs:611:25
    |
611 |                     let mut window_attrs = WinitWindow::default_attributes()
    |                         ----^^^^^^^^^^^^
    |                         |
    |                         help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

Check warning on line 599 in frontend/desktop/src/ui/window.rs

See this annotation in the file changed.

@github-actions github-actions / Run clippy (ubuntu-latest, all features)

use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead

warning: use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead
   --> frontend/desktop/src/ui/window.rs:599:33
    |
599 |         let _ = self.event_loop.run(move |event, elwt| {
    |                                 ^^^
    |
    = note: `#[warn(deprecated)]` on by default