Fix DLDI, other small changes #21
kelpsyberryAnnotations
3 errors and 49 warnings
|
Run Clippy and test (ubuntu-latest)
Clippy had exited with the 101 exit code
|
|
Run Clippy and test (macos-latest)
The operation was canceled.
|
|
Run Clippy and test (windows-latest)
The operation was canceled.
|
|
returning the result of a `let` binding from a block:
core/src/gpu/engine_3d.rs#L587
warning: returning the result of a `let` binding from a block
--> core/src/gpu/engine_3d.rs:587:9
|
580 | let result = CMD_PARAMS[command as usize];
| ------------------------------------------ unnecessary `let` binding
...
587 | result
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
580 ~
581 | #[cfg(feature = "log")]
...
586 | }
587 ~ CMD_PARAMS[command as usize]
|
|
|
unused `self` argument:
core/src/gpu/engine_3d.rs#L579
warning: unused `self` argument
--> core/src/gpu/engine_3d.rs:579:27
|
579 | fn params_for_command(&self, command: u8) -> u8 {
| ^^^^^
|
= help: consider refactoring to an associated function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_self
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_3d/io.rs#L422
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_3d/io.rs:422:28
|
422 | pub(crate) fn write_32<A: AccessType, E: cpu::Engine>(
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_3d/io.rs#L305
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_3d/io.rs:305:28
|
305 | pub(crate) fn write_16<A: AccessType, E: cpu::Engine>(
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_3d/io.rs#L146
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_3d/io.rs:146:27
|
146 | pub(crate) fn write_8<A: AccessType, E: cpu::Engine>(emu: &mut Emu<E>, addr: u16, value: u8) {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_3d/io.rs#L115
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_3d/io.rs:115:26
|
115 | pub(crate) fn read_32<A: AccessType>(&mut self, addr: u16) -> u32 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_3d/io.rs#L75
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_3d/io.rs:75:26
|
75 | pub(crate) fn read_16<A: AccessType>(&mut self, addr: u16) -> u16 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_3d/io.rs#L30
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_3d/io.rs:30:25
|
30 | pub(crate) fn read_8<A: AccessType>(&mut self, addr: u16) -> u8 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_2d/io.rs#L314
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_2d/io.rs:314:27
|
314 | pub(crate) fn write_32<A: AccessType>(&mut self, addr: u32, value: u32) {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_2d/io.rs#L204
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_2d/io.rs:204:27
|
204 | pub(crate) fn write_16<A: AccessType>(&mut self, addr: u32, value: u16) {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_2d/io.rs#L88
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_2d/io.rs:88:26
|
88 | pub(crate) fn write_8<A: AccessType>(&mut self, addr: u32, value: u8) {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_2d/io.rs#L63
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_2d/io.rs:63:26
|
63 | pub(crate) fn read_32<A: AccessType>(&mut self, addr: u32) -> u32 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_2d/io.rs#L37
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_2d/io.rs:37:26
|
37 | pub(crate) fn read_16<A: AccessType>(&mut self, addr: u32) -> u16 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_2d/io.rs#L8
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_2d/io.rs:8:25
|
8 | pub(crate) fn read_8<A: AccessType>(&mut self, addr: u32) -> u8 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/audio/io.rs#L335
warning: type parameter `A` goes unused in function definition
--> core/src/audio/io.rs:335:27
|
335 | pub(crate) fn write_32<A: AccessType>(&mut self, addr: u32, value: u32) {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/audio/io.rs#L256
warning: type parameter `A` goes unused in function definition
--> core/src/audio/io.rs:256:27
|
256 | pub(crate) fn write_16<A: AccessType>(&mut self, addr: u32, value: u16) {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/audio/io.rs#L125
warning: type parameter `A` goes unused in function definition
--> core/src/audio/io.rs:125:26
|
125 | pub(crate) fn write_8<A: AccessType>(&mut self, addr: u32, value: u8) {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/audio/io.rs#L94
warning: type parameter `A` goes unused in function definition
--> core/src/audio/io.rs:94:26
|
94 | pub(crate) fn read_32<A: AccessType>(&mut self, addr: u32) -> u32 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/audio/io.rs#L54
warning: type parameter `A` goes unused in function definition
--> core/src/audio/io.rs:54:26
|
54 | pub(crate) fn read_16<A: AccessType>(&mut self, addr: u32) -> u16 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/audio/io.rs#L5
warning: type parameter `A` goes unused in function definition
--> core/src/audio/io.rs:5:25
|
5 | pub(crate) fn read_8<A: AccessType>(&mut self, addr: u32) -> u8 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
= note: `#[warn(clippy::extra_unused_type_parameters)]` on by default
|
|
unused `self` argument:
core/src/audio/channel.rs#L339
warning: unused `self` argument
--> core/src/audio/channel.rs:339:25
|
339 | fn keep_last_sample(&mut self) {
| ^^^^^^^^^
|
= help: consider refactoring to an associated function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_self
|
|
unused `self` argument:
core/src/audio/channel.rs#L258
warning: unused `self` argument
--> core/src/audio/channel.rs:258:25
|
258 | fn check_total_size(&self) {
| ^^^^^
|
= help: consider refactoring to an associated function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_self
|
|
unused `self` argument:
core/src/audio/channel.rs#L250
warning: unused `self` argument
--> core/src/audio/channel.rs:250:25
|
250 | fn check_loop_start(&self) {
| ^^^^^
|
= help: consider refactoring to an associated function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_self
note: the lint level is defined here
--> core/src/lib.rs:11:9
|
11 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::unused_self)]` implied by `#[warn(clippy::pedantic)]`
|
|
returning the result of a `let` binding from a block:
core/src/gpu/engine_3d.rs#L587
warning: returning the result of a `let` binding from a block
--> core/src/gpu/engine_3d.rs:587:9
|
580 | let result = CMD_PARAMS[command as usize];
| ------------------------------------------ unnecessary `let` binding
...
587 | result
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
580 ~
581 | #[cfg(feature = "log")]
...
586 | }
587 ~ CMD_PARAMS[command as usize]
|
|
|
unused `self` argument:
core/src/gpu/engine_3d.rs#L579
warning: unused `self` argument
--> core/src/gpu/engine_3d.rs:579:27
|
579 | fn params_for_command(&self, command: u8) -> u8 {
| ^^^^^
|
= help: consider refactoring to an associated function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_self
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_3d/io.rs#L422
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_3d/io.rs:422:28
|
422 | pub(crate) fn write_32<A: AccessType, E: cpu::Engine>(
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_3d/io.rs#L305
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_3d/io.rs:305:28
|
305 | pub(crate) fn write_16<A: AccessType, E: cpu::Engine>(
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_3d/io.rs#L146
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_3d/io.rs:146:27
|
146 | pub(crate) fn write_8<A: AccessType, E: cpu::Engine>(emu: &mut Emu<E>, addr: u16, value: u8) {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_3d/io.rs#L115
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_3d/io.rs:115:26
|
115 | pub(crate) fn read_32<A: AccessType>(&mut self, addr: u16) -> u32 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_3d/io.rs#L75
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_3d/io.rs:75:26
|
75 | pub(crate) fn read_16<A: AccessType>(&mut self, addr: u16) -> u16 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_3d/io.rs#L30
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_3d/io.rs:30:25
|
30 | pub(crate) fn read_8<A: AccessType>(&mut self, addr: u16) -> u8 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_2d/io.rs#L314
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_2d/io.rs:314:27
|
314 | pub(crate) fn write_32<A: AccessType>(&mut self, addr: u32, value: u32) {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_2d/io.rs#L204
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_2d/io.rs:204:27
|
204 | pub(crate) fn write_16<A: AccessType>(&mut self, addr: u32, value: u16) {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_2d/io.rs#L88
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_2d/io.rs:88:26
|
88 | pub(crate) fn write_8<A: AccessType>(&mut self, addr: u32, value: u8) {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_2d/io.rs#L63
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_2d/io.rs:63:26
|
63 | pub(crate) fn read_32<A: AccessType>(&mut self, addr: u32) -> u32 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_2d/io.rs#L37
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_2d/io.rs:37:26
|
37 | pub(crate) fn read_16<A: AccessType>(&mut self, addr: u32) -> u16 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/gpu/engine_2d/io.rs#L8
warning: type parameter `A` goes unused in function definition
--> core/src/gpu/engine_2d/io.rs:8:25
|
8 | pub(crate) fn read_8<A: AccessType>(&mut self, addr: u32) -> u8 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/audio/io.rs#L335
warning: type parameter `A` goes unused in function definition
--> core/src/audio/io.rs:335:27
|
335 | pub(crate) fn write_32<A: AccessType>(&mut self, addr: u32, value: u32) {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/audio/io.rs#L256
warning: type parameter `A` goes unused in function definition
--> core/src/audio/io.rs:256:27
|
256 | pub(crate) fn write_16<A: AccessType>(&mut self, addr: u32, value: u16) {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/audio/io.rs#L125
warning: type parameter `A` goes unused in function definition
--> core/src/audio/io.rs:125:26
|
125 | pub(crate) fn write_8<A: AccessType>(&mut self, addr: u32, value: u8) {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/audio/io.rs#L94
warning: type parameter `A` goes unused in function definition
--> core/src/audio/io.rs:94:26
|
94 | pub(crate) fn read_32<A: AccessType>(&mut self, addr: u32) -> u32 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/audio/io.rs#L54
warning: type parameter `A` goes unused in function definition
--> core/src/audio/io.rs:54:26
|
54 | pub(crate) fn read_16<A: AccessType>(&mut self, addr: u32) -> u16 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameter `A` goes unused in function definition:
core/src/audio/io.rs#L5
warning: type parameter `A` goes unused in function definition
--> core/src/audio/io.rs:5:25
|
5 | pub(crate) fn read_8<A: AccessType>(&mut self, addr: u32) -> u8 {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
= note: `#[warn(clippy::extra_unused_type_parameters)]` on by default
|
|
unused `self` argument:
core/src/audio/channel.rs#L339
warning: unused `self` argument
--> core/src/audio/channel.rs:339:25
|
339 | fn keep_last_sample(&mut self) {
| ^^^^^^^^^
|
= help: consider refactoring to an associated function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_self
|
|
unused `self` argument:
core/src/audio/channel.rs#L258
warning: unused `self` argument
--> core/src/audio/channel.rs:258:25
|
258 | fn check_total_size(&self) {
| ^^^^^
|
= help: consider refactoring to an associated function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_self
|
|
unused `self` argument:
core/src/audio/channel.rs#L250
warning: unused `self` argument
--> core/src/audio/channel.rs:250:25
|
250 | fn check_loop_start(&self) {
| ^^^^^
|
= help: consider refactoring to an associated function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_self
note: the lint level is defined here
--> core/src/lib.rs:11:9
|
11 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::unused_self)]` implied by `#[warn(clippy::pedantic)]`
|
|
Run Clippy and test (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Run Clippy and test (macos-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Run Clippy and test (windows-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|