Skip to content

Clean up warnings and nightly features #56

Clean up warnings and nightly features

Clean up warnings and nightly features #56

Triggered via push November 2, 2024 17:01
Status Success
Total duration 9m 15s
Artifacts 3
Fit to window
Zoom out
Zoom in

Annotations

141 warnings
the following explicit lifetimes could be elided: 'a: frontend/desktop/src/input/map.rs#L127
warning: the following explicit lifetimes could be elided: 'a --> frontend/desktop/src/input/map.rs:127:14 | 127 | impl<'a, T: 'static + Eq, U: 'static + Serialize> Serialize for TriggerMap<'a, T, U> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 127 - impl<'a, T: 'static + Eq, U: 'static + Serialize> Serialize for TriggerMap<'a, T, U> { 127 + impl<T: 'static + Eq, U: 'static + Serialize> Serialize for TriggerMap<'_, T, U> { |
the following explicit lifetimes could be elided: 'de: frontend/desktop/src/utils.rs#L114
warning: the following explicit lifetimes could be elided: 'de --> frontend/desktop/src/utils.rs:114:6 | 114 | impl<'de> serde::de::Visitor<'de> for HomePathBufVisitor { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes note: the lint level is defined here --> frontend/desktop/src/main.rs:9:9 | 9 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::needless_lifetimes)]` implied by `#[warn(clippy::all)]` help: elide the lifetimes | 114 - impl<'de> serde::de::Visitor<'de> for HomePathBufVisitor { 114 + impl serde::de::Visitor<'_> for HomePathBufVisitor { |
use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead: frontend/desktop/src/ui/window.rs#L599
warning: use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead --> frontend/desktop/src/ui/window.rs:599:33 | 599 | let _ = self.event_loop.run(move |event, elwt| { | ^^^ | = note: `#[warn(deprecated)]` on by default
manually reimplementing `div_ceil`: render/wgpu-3d/src/utils.rs#L6
warning: manually reimplementing `div_ceil` --> render/wgpu-3d/src/utils.rs:6:5 | 6 | (size + alignment - 1) / alignment * alignment | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(alignment)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil note: the lint level is defined here --> render/wgpu-3d/src/lib.rs:2:9 | 2 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::manual_div_ceil)]` implied by `#[warn(clippy::all)]`
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 1178 | / unmap_region!( 1179 | | wb self, 1180 | | arm7, 0x4_0000, 17, 0, 1181 | | ( ... | 1186 | | bank, MASK, BANK_BIT, false, region 1187 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 1154 | / map_region!( 1155 | | wb self, 1156 | | arm7, 0x4_0000, 17, 0, 1157 | | ( ... | 1162 | | bank, MASK, BANK_BIT, region 1163 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 1081 | / unmap_region!( 1082 | | wb self, 1083 | | b_obj, 0x2_0000, 17, 2, bg_obj_updates, 1084 | | ( ... | 1089 | | bank, MASK, BANK_BIT, false, 0 1090 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 1056 | / map_region!( 1057 | | wb self, 1058 | | b_obj, 0x2_0000, 17, 2, bg_obj_updates, 1059 | | ( ... | 1064 | | bank, MASK, BANK_BIT, 0 1065 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 1034 | / unmap_region!( 1035 | | wb self, 1036 | | b_bg, 0x2_0000, 15, 6, bg_obj_updates, 1037 | | ( ... | 1043 | | bank, MASK, BANK_BIT, IS_MIRROR, region 1044 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 1003 | / map_region!( 1004 | | wb self, 1005 | | b_bg, 0x2_0000, 15, 6, bg_obj_updates, 1006 | | ( ... | 1012 | | bank, MASK, BANK_BIT, region 1013 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 907 | / unmap_region!( 908 | | wb self, 909 | | a_obj, 0x4_0000, 14, 0x18, bg_obj_updates, 910 | | ( ... | 918 | | bank, MASK, BANK_BIT, IS_MIRROR, region 919 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 874 | / map_region!( 875 | | wb self, 876 | | a_obj, 0x4_0000, 14, 0x18, bg_obj_updates, 877 | | ( ... | 885 | | bank, MASK, BANK_BIT, region 886 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 840 | / unmap_region!( 841 | | wb self, 842 | | a_bg, 0x8_0000, 14, 0x60, bg_obj_updates, 843 | | ( ... | 853 | | bank, MASK, BANK_BIT, IS_MIRROR, region 854 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 805 | / map_region!( 806 | | wb self, 807 | | a_bg, 0x8_0000, 14, 0x60, bg_obj_updates, 808 | | ( ... | 818 | | bank, MASK, BANK_BIT, region 819 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 728 | / restore_region!( 729 | | cpu_visible arm7, arm7_ptr_mask::R, arm7_ptr_mask::ALL, 730 | | arm7, 0x4_0000, 17, 0, 731 | | 0x0600_0000, 0x0700_0000, ... | 735 | | ) 736 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 719 | / restore_region!( 720 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 721 | | b_obj, 0x2_0000, 17, 2, 722 | | 0x0660_0000, 0x0680_0000, bg_obj_updates, ... | 726 | | ) 727 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 709 | / restore_region!( 710 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 711 | | b_bg, 0x2_0000, 15, 6, 712 | | 0x0620_0000, 0x0640_0000, bg_obj_updates, ... | 717 | | ) 718 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 697 | / restore_region!( 698 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 699 | | a_obj, 0x4_0000, 14, 0x18, 700 | | 0x0640_0000, 0x0660_0000, bg_obj_updates, ... | 707 | | ) 708 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 683 | / restore_region!( 684 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 685 | | a_bg, 0x8_0000, 14, 0x60, 686 | | 0x0600_0000, 0x0620_0000, bg_obj_updates, ... | 695 | | ) 696 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 674 | / restore_region!( 675 | | tex_pal, 14, 676 | | ( 677 | | 0 => e, 0xFFFF, ... | 680 | | ) 681 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 665 | / restore_region!( 666 | | texture, 17, 667 | | ( 668 | | 0 => a, 0x1_FFFF, ... | 672 | | ) 673 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 658 | / restore_region!( 659 | | a_obj_ext_pal, 13, 660 | | ( 661 | | 0 => f, 0x3FFF, 662 | | 1 => g, 0x3FFF, 663 | | ) 664 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 650 | / restore_region!( 651 | | a_bg_ext_pal, 14, 652 | | ( 653 | | 0 => e, 0xFFFF, ... | 656 | | ) 657 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 485 | / restore_region!( 486 | | arm9, 487 | | ptr_mask::R, 488 | | ptr_mask::R | ptr_mask::W_16_32, ... | 494 | | 0x0680_0000 495 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 474 | / restore_region!( 475 | | arm9, 476 | | ptr_mask::R, 477 | | ptr_mask::R | ptr_mask::W_16_32, ... | 483 | | 0x0640_0000 484 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 463 | / restore_region!( 464 | | arm9, 465 | | ptr_mask::R, 466 | | ptr_mask::R | ptr_mask::W_16_32, ... | 472 | | 0x0660_0000 473 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 452 | / restore_region!( 453 | | arm9, 454 | | ptr_mask::R, 455 | | ptr_mask::R | ptr_mask::W_16_32, ... | 461 | | 0x0620_0000 462 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 409 | / flush_usage!( 410 | | arm7, 17, 0, 411 | | ( 412 | | 0 => c, 0x1_FFFF, 413 | | 1 => d, 0x1_FFFF, 414 | | ) 415 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 394 | / flush_usage!( 395 | | b_bg, 15, 6, 396 | | ( 397 | | 0 => c, 0x1_FFFF, ... | 400 | | ) 401 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 384 | / flush_usage!( 385 | | a_obj, 14, 0x18, 386 | | ( 387 | | 0 => a, 0x1_FFFF, ... | 392 | | ) 393 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 372 | / flush_usage!( 373 | | a_bg, 14, 0x60, 374 | | ( 375 | | 0 => a, 0x1_FFFF, ... | 382 | | ) 383 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/cpu/interpreter/arm9/thumb/mem.rs#L544
warning: manually reimplementing `is_power_of_two` --> core/src/cpu/interpreter/arm9/thumb/mem.rs:544:8 | 544 | if instr as u8 & (instr as u8 - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `instr as u8.is_power_of_two()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two
manually reimplementing `is_power_of_two`: core/src/cpu/interpreter/arm9/thumb/mem.rs#L472
warning: manually reimplementing `is_power_of_two` --> core/src/cpu/interpreter/arm9/thumb/mem.rs:472:12 | 472 | if instr as u8 & (instr as u8 - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `instr as u8.is_power_of_two()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two
manually reimplementing `is_power_of_two`: core/src/cpu/interpreter/arm9/arm/mem.rs#L811
warning: manually reimplementing `is_power_of_two` --> core/src/cpu/interpreter/arm9/arm/mem.rs:811:12 | 811 | if instr as u16 & (instr as u16 - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `instr as u16.is_power_of_two()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two note: the lint level is defined here --> core/src/lib.rs:15:9 | 15 | #![warn(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::manual_is_power_of_two)]` implied by `#[warn(clippy::pedantic)]`
empty line after outer attribute: frontend/desktop/src/ui.rs#L1482
warning: empty line after outer attribute --> frontend/desktop/src/ui.rs:1482:33 | 1482 | / ... #[cfg(feature = "gdb-server")] 1483 | | ... | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr = note: `#[warn(clippy::empty_line_after_outer_attr)]` implied by `#[warn(clippy::all)]` = help: if the empty line is unintentional remove it
the following explicit lifetimes could be elided: 'a: frontend/desktop/src/input/map.rs#L127
warning: the following explicit lifetimes could be elided: 'a --> frontend/desktop/src/input/map.rs:127:14 | 127 | impl<'a, T: 'static + Eq, U: 'static + Serialize> Serialize for TriggerMap<'a, T, U> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 127 - impl<'a, T: 'static + Eq, U: 'static + Serialize> Serialize for TriggerMap<'a, T, U> { 127 + impl<T: 'static + Eq, U: 'static + Serialize> Serialize for TriggerMap<'_, T, U> { |
the following explicit lifetimes could be elided: 'de: frontend/desktop/src/utils.rs#L114
warning: the following explicit lifetimes could be elided: 'de --> frontend/desktop/src/utils.rs:114:6 | 114 | impl<'de> serde::de::Visitor<'de> for HomePathBufVisitor { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes note: the lint level is defined here --> frontend/desktop/src/main.rs:9:9 | 9 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::needless_lifetimes)]` implied by `#[warn(clippy::all)]` help: elide the lifetimes | 114 - impl<'de> serde::de::Visitor<'de> for HomePathBufVisitor { 114 + impl serde::de::Visitor<'_> for HomePathBufVisitor { |
use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead: frontend/desktop/src/ui/window.rs#L599
warning: use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead --> frontend/desktop/src/ui/window.rs:599:33 | 599 | let _ = self.event_loop.run(move |event, elwt| { | ^^^ | = note: `#[warn(deprecated)]` on by default
manually reimplementing `div_ceil`: render/wgpu-3d/src/utils.rs#L6
warning: manually reimplementing `div_ceil` --> render/wgpu-3d/src/utils.rs:6:5 | 6 | (size + alignment - 1) / alignment * alignment | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(alignment)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil note: the lint level is defined here --> render/wgpu-3d/src/lib.rs:2:9 | 2 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::manual_div_ceil)]` implied by `#[warn(clippy::all)]`
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 1178 | / unmap_region!( 1179 | | wb self, 1180 | | arm7, 0x4_0000, 17, 0, 1181 | | ( ... | 1186 | | bank, MASK, BANK_BIT, false, region 1187 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 1154 | / map_region!( 1155 | | wb self, 1156 | | arm7, 0x4_0000, 17, 0, 1157 | | ( ... | 1162 | | bank, MASK, BANK_BIT, region 1163 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 1081 | / unmap_region!( 1082 | | wb self, 1083 | | b_obj, 0x2_0000, 17, 2, bg_obj_updates, 1084 | | ( ... | 1089 | | bank, MASK, BANK_BIT, false, 0 1090 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 1056 | / map_region!( 1057 | | wb self, 1058 | | b_obj, 0x2_0000, 17, 2, bg_obj_updates, 1059 | | ( ... | 1064 | | bank, MASK, BANK_BIT, 0 1065 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 1034 | / unmap_region!( 1035 | | wb self, 1036 | | b_bg, 0x2_0000, 15, 6, bg_obj_updates, 1037 | | ( ... | 1043 | | bank, MASK, BANK_BIT, IS_MIRROR, region 1044 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 1003 | / map_region!( 1004 | | wb self, 1005 | | b_bg, 0x2_0000, 15, 6, bg_obj_updates, 1006 | | ( ... | 1012 | | bank, MASK, BANK_BIT, region 1013 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 907 | / unmap_region!( 908 | | wb self, 909 | | a_obj, 0x4_0000, 14, 0x18, bg_obj_updates, 910 | | ( ... | 918 | | bank, MASK, BANK_BIT, IS_MIRROR, region 919 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 874 | / map_region!( 875 | | wb self, 876 | | a_obj, 0x4_0000, 14, 0x18, bg_obj_updates, 877 | | ( ... | 885 | | bank, MASK, BANK_BIT, region 886 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 840 | / unmap_region!( 841 | | wb self, 842 | | a_bg, 0x8_0000, 14, 0x60, bg_obj_updates, 843 | | ( ... | 853 | | bank, MASK, BANK_BIT, IS_MIRROR, region 854 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 805 | / map_region!( 806 | | wb self, 807 | | a_bg, 0x8_0000, 14, 0x60, bg_obj_updates, 808 | | ( ... | 818 | | bank, MASK, BANK_BIT, region 819 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 728 | / restore_region!( 729 | | cpu_visible arm7, arm7_ptr_mask::R, arm7_ptr_mask::ALL, 730 | | arm7, 0x4_0000, 17, 0, 731 | | 0x0600_0000, 0x0700_0000, ... | 735 | | ) 736 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 719 | / restore_region!( 720 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 721 | | b_obj, 0x2_0000, 17, 2, 722 | | 0x0660_0000, 0x0680_0000, bg_obj_updates, ... | 726 | | ) 727 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 709 | / restore_region!( 710 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 711 | | b_bg, 0x2_0000, 15, 6, 712 | | 0x0620_0000, 0x0640_0000, bg_obj_updates, ... | 717 | | ) 718 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 697 | / restore_region!( 698 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 699 | | a_obj, 0x4_0000, 14, 0x18, 700 | | 0x0640_0000, 0x0660_0000, bg_obj_updates, ... | 707 | | ) 708 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 683 | / restore_region!( 684 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 685 | | a_bg, 0x8_0000, 14, 0x60, 686 | | 0x0600_0000, 0x0620_0000, bg_obj_updates, ... | 695 | | ) 696 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 674 | / restore_region!( 675 | | tex_pal, 14, 676 | | ( 677 | | 0 => e, 0xFFFF, ... | 680 | | ) 681 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 665 | / restore_region!( 666 | | texture, 17, 667 | | ( 668 | | 0 => a, 0x1_FFFF, ... | 672 | | ) 673 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 658 | / restore_region!( 659 | | a_obj_ext_pal, 13, 660 | | ( 661 | | 0 => f, 0x3FFF, 662 | | 1 => g, 0x3FFF, 663 | | ) 664 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 650 | / restore_region!( 651 | | a_bg_ext_pal, 14, 652 | | ( 653 | | 0 => e, 0xFFFF, ... | 656 | | ) 657 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 485 | / restore_region!( 486 | | arm9, 487 | | ptr_mask::R, 488 | | ptr_mask::R | ptr_mask::W_16_32, ... | 494 | | 0x0680_0000 495 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 474 | / restore_region!( 475 | | arm9, 476 | | ptr_mask::R, 477 | | ptr_mask::R | ptr_mask::W_16_32, ... | 483 | | 0x0640_0000 484 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 463 | / restore_region!( 464 | | arm9, 465 | | ptr_mask::R, 466 | | ptr_mask::R | ptr_mask::W_16_32, ... | 472 | | 0x0660_0000 473 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 452 | / restore_region!( 453 | | arm9, 454 | | ptr_mask::R, 455 | | ptr_mask::R | ptr_mask::W_16_32, ... | 461 | | 0x0620_0000 462 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 409 | / flush_usage!( 410 | | arm7, 17, 0, 411 | | ( 412 | | 0 => c, 0x1_FFFF, 413 | | 1 => d, 0x1_FFFF, 414 | | ) 415 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 402 | / flush_usage!( 403 | | b_obj, 17, 2, 404 | | ( 405 | | 0 => d, 0x1_FFFF, 406 | | 1 => i, 0x3FFF, 407 | | ) 408 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 394 | / flush_usage!( 395 | | b_bg, 15, 6, 396 | | ( 397 | | 0 => c, 0x1_FFFF, ... | 400 | | ) 401 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 384 | / flush_usage!( 385 | | a_obj, 14, 0x18, 386 | | ( 387 | | 0 => a, 0x1_FFFF, ... | 392 | | ) 393 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 372 | / flush_usage!( 373 | | a_bg, 14, 0x60, 374 | | ( 375 | | 0 => a, 0x1_FFFF, ... | 382 | | ) 383 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/cpu/interpreter/arm9/thumb/mem.rs#L544
warning: manually reimplementing `is_power_of_two` --> core/src/cpu/interpreter/arm9/thumb/mem.rs:544:8 | 544 | if instr as u8 & (instr as u8 - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `instr as u8.is_power_of_two()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two
manually reimplementing `is_power_of_two`: core/src/cpu/interpreter/arm9/thumb/mem.rs#L472
warning: manually reimplementing `is_power_of_two` --> core/src/cpu/interpreter/arm9/thumb/mem.rs:472:12 | 472 | if instr as u8 & (instr as u8 - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `instr as u8.is_power_of_two()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two
manually reimplementing `is_power_of_two`: core/src/cpu/interpreter/arm9/arm/mem.rs#L811
warning: manually reimplementing `is_power_of_two` --> core/src/cpu/interpreter/arm9/arm/mem.rs:811:12 | 811 | if instr as u16 & (instr as u16 - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `instr as u16.is_power_of_two()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two note: the lint level is defined here --> core/src/lib.rs:15:9 | 15 | #![warn(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::manual_is_power_of_two)]` implied by `#[warn(clippy::pedantic)]`
the following explicit lifetimes could be elided: 'a: frontend/desktop/src/input/map.rs#L127
warning: the following explicit lifetimes could be elided: 'a --> frontend/desktop/src/input/map.rs:127:14 | 127 | impl<'a, T: 'static + Eq, U: 'static + Serialize> Serialize for TriggerMap<'a, T, U> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 127 - impl<'a, T: 'static + Eq, U: 'static + Serialize> Serialize for TriggerMap<'a, T, U> { 127 + impl<T: 'static + Eq, U: 'static + Serialize> Serialize for TriggerMap<'_, T, U> { |
the following explicit lifetimes could be elided: 'de: frontend/desktop/src/utils.rs#L114
warning: the following explicit lifetimes could be elided: 'de --> frontend/desktop/src/utils.rs:114:6 | 114 | impl<'de> serde::de::Visitor<'de> for HomePathBufVisitor { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes note: the lint level is defined here --> frontend/desktop/src/main.rs:9:9 | 9 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::needless_lifetimes)]` implied by `#[warn(clippy::all)]` help: elide the lifetimes | 114 - impl<'de> serde::de::Visitor<'de> for HomePathBufVisitor { 114 + impl serde::de::Visitor<'_> for HomePathBufVisitor { |
use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead: frontend/desktop/src/ui/window.rs#L599
warning: use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead --> frontend/desktop/src/ui/window.rs:599:33 | 599 | let _ = self.event_loop.run(move |event, elwt| { | ^^^ | = note: `#[warn(deprecated)]` on by default
manually reimplementing `div_ceil`: render/wgpu-3d/src/utils.rs#L6
warning: manually reimplementing `div_ceil` --> render/wgpu-3d/src/utils.rs:6:5 | 6 | (size + alignment - 1) / alignment * alignment | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(alignment)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil note: the lint level is defined here --> render/wgpu-3d/src/lib.rs:2:9 | 2 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::manual_div_ceil)]` implied by `#[warn(clippy::all)]`
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 1178 | / unmap_region!( 1179 | | wb self, 1180 | | arm7, 0x4_0000, 17, 0, 1181 | | ( ... | 1186 | | bank, MASK, BANK_BIT, false, region 1187 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 1154 | / map_region!( 1155 | | wb self, 1156 | | arm7, 0x4_0000, 17, 0, 1157 | | ( ... | 1162 | | bank, MASK, BANK_BIT, region 1163 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 1081 | / unmap_region!( 1082 | | wb self, 1083 | | b_obj, 0x2_0000, 17, 2, bg_obj_updates, 1084 | | ( ... | 1089 | | bank, MASK, BANK_BIT, false, 0 1090 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 1056 | / map_region!( 1057 | | wb self, 1058 | | b_obj, 0x2_0000, 17, 2, bg_obj_updates, 1059 | | ( ... | 1064 | | bank, MASK, BANK_BIT, 0 1065 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 1034 | / unmap_region!( 1035 | | wb self, 1036 | | b_bg, 0x2_0000, 15, 6, bg_obj_updates, 1037 | | ( ... | 1043 | | bank, MASK, BANK_BIT, IS_MIRROR, region 1044 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 1003 | / map_region!( 1004 | | wb self, 1005 | | b_bg, 0x2_0000, 15, 6, bg_obj_updates, 1006 | | ( ... | 1012 | | bank, MASK, BANK_BIT, region 1013 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 907 | / unmap_region!( 908 | | wb self, 909 | | a_obj, 0x4_0000, 14, 0x18, bg_obj_updates, 910 | | ( ... | 918 | | bank, MASK, BANK_BIT, IS_MIRROR, region 919 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 874 | / map_region!( 875 | | wb self, 876 | | a_obj, 0x4_0000, 14, 0x18, bg_obj_updates, 877 | | ( ... | 885 | | bank, MASK, BANK_BIT, region 886 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 840 | / unmap_region!( 841 | | wb self, 842 | | a_bg, 0x8_0000, 14, 0x60, bg_obj_updates, 843 | | ( ... | 853 | | bank, MASK, BANK_BIT, IS_MIRROR, region 854 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 805 | / map_region!( 806 | | wb self, 807 | | a_bg, 0x8_0000, 14, 0x60, bg_obj_updates, 808 | | ( ... | 818 | | bank, MASK, BANK_BIT, region 819 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 728 | / restore_region!( 729 | | cpu_visible arm7, arm7_ptr_mask::R, arm7_ptr_mask::ALL, 730 | | arm7, 0x4_0000, 17, 0, 731 | | 0x0600_0000, 0x0700_0000, ... | 735 | | ) 736 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 719 | / restore_region!( 720 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 721 | | b_obj, 0x2_0000, 17, 2, 722 | | 0x0660_0000, 0x0680_0000, bg_obj_updates, ... | 726 | | ) 727 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 709 | / restore_region!( 710 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 711 | | b_bg, 0x2_0000, 15, 6, 712 | | 0x0620_0000, 0x0640_0000, bg_obj_updates, ... | 717 | | ) 718 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 697 | / restore_region!( 698 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 699 | | a_obj, 0x4_0000, 14, 0x18, 700 | | 0x0640_0000, 0x0660_0000, bg_obj_updates, ... | 707 | | ) 708 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 683 | / restore_region!( 684 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 685 | | a_bg, 0x8_0000, 14, 0x60, 686 | | 0x0600_0000, 0x0620_0000, bg_obj_updates, ... | 695 | | ) 696 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 674 | / restore_region!( 675 | | tex_pal, 14, 676 | | ( 677 | | 0 => e, 0xFFFF, ... | 680 | | ) 681 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 665 | / restore_region!( 666 | | texture, 17, 667 | | ( 668 | | 0 => a, 0x1_FFFF, ... | 672 | | ) 673 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 658 | / restore_region!( 659 | | a_obj_ext_pal, 13, 660 | | ( 661 | | 0 => f, 0x3FFF, 662 | | 1 => g, 0x3FFF, 663 | | ) 664 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 650 | / restore_region!( 651 | | a_bg_ext_pal, 14, 652 | | ( 653 | | 0 => e, 0xFFFF, ... | 656 | | ) 657 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 485 | / restore_region!( 486 | | arm9, 487 | | ptr_mask::R, 488 | | ptr_mask::R | ptr_mask::W_16_32, ... | 494 | | 0x0680_0000 495 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 474 | / restore_region!( 475 | | arm9, 476 | | ptr_mask::R, 477 | | ptr_mask::R | ptr_mask::W_16_32, ... | 483 | | 0x0640_0000 484 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 463 | / restore_region!( 464 | | arm9, 465 | | ptr_mask::R, 466 | | ptr_mask::R | ptr_mask::W_16_32, ... | 472 | | 0x0660_0000 473 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 452 | / restore_region!( 453 | | arm9, 454 | | ptr_mask::R, 455 | | ptr_mask::R | ptr_mask::W_16_32, ... | 461 | | 0x0620_0000 462 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 409 | / flush_usage!( 410 | | arm7, 17, 0, 411 | | ( 412 | | 0 => c, 0x1_FFFF, 413 | | 1 => d, 0x1_FFFF, 414 | | ) 415 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 402 | / flush_usage!( 403 | | b_obj, 17, 2, 404 | | ( 405 | | 0 => d, 0x1_FFFF, 406 | | 1 => i, 0x3FFF, 407 | | ) 408 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 394 | / flush_usage!( 395 | | b_bg, 15, 6, 396 | | ( 397 | | 0 => c, 0x1_FFFF, ... | 400 | | ) 401 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 384 | / flush_usage!( 385 | | a_obj, 14, 0x18, 386 | | ( 387 | | 0 => a, 0x1_FFFF, ... | 392 | | ) 393 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 372 | / flush_usage!( 373 | | a_bg, 14, 0x60, 374 | | ( 375 | | 0 => a, 0x1_FFFF, ... | 382 | | ) 383 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/cpu/interpreter/arm9/thumb/mem.rs#L544
warning: manually reimplementing `is_power_of_two` --> core/src/cpu/interpreter/arm9/thumb/mem.rs:544:8 | 544 | if instr as u8 & (instr as u8 - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `instr as u8.is_power_of_two()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two
manually reimplementing `is_power_of_two`: core/src/cpu/interpreter/arm9/thumb/mem.rs#L472
warning: manually reimplementing `is_power_of_two` --> core/src/cpu/interpreter/arm9/thumb/mem.rs:472:12 | 472 | if instr as u8 & (instr as u8 - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `instr as u8.is_power_of_two()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two
manually reimplementing `is_power_of_two`: core/src/cpu/interpreter/arm9/arm/mem.rs#L811
warning: manually reimplementing `is_power_of_two` --> core/src/cpu/interpreter/arm9/arm/mem.rs:811:12 | 811 | if instr as u16 & (instr as u16 - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `instr as u16.is_power_of_two()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two note: the lint level is defined here --> core/src/lib.rs:15:9 | 15 | #![warn(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::manual_is_power_of_two)]` implied by `#[warn(clippy::pedantic)]`
empty line after outer attribute: frontend/desktop/src/ui.rs#L1482
warning: empty line after outer attribute --> frontend/desktop/src/ui.rs:1482:33 | 1482 | / ... #[cfg(feature = "gdb-server")] 1483 | | ... | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr = note: `#[warn(clippy::empty_line_after_outer_attr)]` implied by `#[warn(clippy::all)]` = help: if the empty line is unintentional remove it
the following explicit lifetimes could be elided: 'a: frontend/desktop/src/input/map.rs#L127
warning: the following explicit lifetimes could be elided: 'a --> frontend/desktop/src/input/map.rs:127:14 | 127 | impl<'a, T: 'static + Eq, U: 'static + Serialize> Serialize for TriggerMap<'a, T, U> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 127 - impl<'a, T: 'static + Eq, U: 'static + Serialize> Serialize for TriggerMap<'a, T, U> { 127 + impl<T: 'static + Eq, U: 'static + Serialize> Serialize for TriggerMap<'_, T, U> { |
the following explicit lifetimes could be elided: 'de: frontend/desktop/src/utils.rs#L114
warning: the following explicit lifetimes could be elided: 'de --> frontend/desktop/src/utils.rs:114:6 | 114 | impl<'de> serde::de::Visitor<'de> for HomePathBufVisitor { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes note: the lint level is defined here --> frontend/desktop/src/main.rs:9:9 | 9 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::needless_lifetimes)]` implied by `#[warn(clippy::all)]` help: elide the lifetimes | 114 - impl<'de> serde::de::Visitor<'de> for HomePathBufVisitor { 114 + impl serde::de::Visitor<'_> for HomePathBufVisitor { |
use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead: frontend/desktop/src/ui/window.rs#L599
warning: use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead --> frontend/desktop/src/ui/window.rs:599:33 | 599 | let _ = self.event_loop.run(move |event, elwt| { | ^^^ | = note: `#[warn(deprecated)]` on by default
manually reimplementing `div_ceil`: render/wgpu-3d/src/utils.rs#L6
warning: manually reimplementing `div_ceil` --> render/wgpu-3d/src/utils.rs:6:5 | 6 | (size + alignment - 1) / alignment * alignment | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(alignment)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil note: the lint level is defined here --> render/wgpu-3d/src/lib.rs:2:9 | 2 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::manual_div_ceil)]` implied by `#[warn(clippy::all)]`
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 1178 | / unmap_region!( 1179 | | wb self, 1180 | | arm7, 0x4_0000, 17, 0, 1181 | | ( ... | 1186 | | bank, MASK, BANK_BIT, false, region 1187 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 1154 | / map_region!( 1155 | | wb self, 1156 | | arm7, 0x4_0000, 17, 0, 1157 | | ( ... | 1162 | | bank, MASK, BANK_BIT, region 1163 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 1081 | / unmap_region!( 1082 | | wb self, 1083 | | b_obj, 0x2_0000, 17, 2, bg_obj_updates, 1084 | | ( ... | 1089 | | bank, MASK, BANK_BIT, false, 0 1090 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 1056 | / map_region!( 1057 | | wb self, 1058 | | b_obj, 0x2_0000, 17, 2, bg_obj_updates, 1059 | | ( ... | 1064 | | bank, MASK, BANK_BIT, 0 1065 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 1034 | / unmap_region!( 1035 | | wb self, 1036 | | b_bg, 0x2_0000, 15, 6, bg_obj_updates, 1037 | | ( ... | 1043 | | bank, MASK, BANK_BIT, IS_MIRROR, region 1044 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 1003 | / map_region!( 1004 | | wb self, 1005 | | b_bg, 0x2_0000, 15, 6, bg_obj_updates, 1006 | | ( ... | 1012 | | bank, MASK, BANK_BIT, region 1013 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 907 | / unmap_region!( 908 | | wb self, 909 | | a_obj, 0x4_0000, 14, 0x18, bg_obj_updates, 910 | | ( ... | 918 | | bank, MASK, BANK_BIT, IS_MIRROR, region 919 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 874 | / map_region!( 875 | | wb self, 876 | | a_obj, 0x4_0000, 14, 0x18, bg_obj_updates, 877 | | ( ... | 885 | | bank, MASK, BANK_BIT, region 886 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L260
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:260:16 | 260 | if new & (new - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `new.is_power_of_two()` ... 840 | / unmap_region!( 841 | | wb self, 842 | | a_bg, 0x8_0000, 14, 0x60, bg_obj_updates, 843 | | ( ... | 853 | | bank, MASK, BANK_BIT, IS_MIRROR, region 854 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `unmap_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L132
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:132:16 | 132 | if prev & (prev - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `prev.is_power_of_two()` ... 805 | / map_region!( 806 | | wb self, 807 | | a_bg, 0x8_0000, 14, 0x60, bg_obj_updates, 808 | | ( ... | 818 | | bank, MASK, BANK_BIT, region 819 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `map_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 728 | / restore_region!( 729 | | cpu_visible arm7, arm7_ptr_mask::R, arm7_ptr_mask::ALL, 730 | | arm7, 0x4_0000, 17, 0, 731 | | 0x0600_0000, 0x0700_0000, ... | 735 | | ) 736 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 719 | / restore_region!( 720 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 721 | | b_obj, 0x2_0000, 17, 2, 722 | | 0x0660_0000, 0x0680_0000, bg_obj_updates, ... | 726 | | ) 727 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 709 | / restore_region!( 710 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 711 | | b_bg, 0x2_0000, 15, 6, 712 | | 0x0620_0000, 0x0640_0000, bg_obj_updates, ... | 717 | | ) 718 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 697 | / restore_region!( 698 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 699 | | a_obj, 0x4_0000, 14, 0x18, 700 | | 0x0640_0000, 0x0660_0000, bg_obj_updates, ... | 707 | | ) 708 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L569
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:569:31 | 569 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 683 | / restore_region!( 684 | | cpu_visible arm9, ptr_mask::R, ptr_mask::R | ptr_mask::W_16_32, 685 | | a_bg, 0x8_0000, 14, 0x60, 686 | | 0x0600_0000, 0x0620_0000, bg_obj_updates, ... | 695 | | ) 696 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 674 | / restore_region!( 675 | | tex_pal, 14, 676 | | ( 677 | | 0 => e, 0xFFFF, ... | 680 | | ) 681 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 665 | / restore_region!( 666 | | texture, 17, 667 | | ( 668 | | 0 => a, 0x1_FFFF, ... | 672 | | ) 673 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 658 | / restore_region!( 659 | | a_obj_ext_pal, 13, 660 | | ( 661 | | 0 => f, 0x3FFF, 662 | | 1 => g, 0x3FFF, 663 | | ) 664 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L619
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:619:31 | 619 | } else if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 650 | / restore_region!( 651 | | a_bg_ext_pal, 14, 652 | | ( 653 | | 0 => e, 0xFFFF, ... | 656 | | ) 657 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 485 | / restore_region!( 486 | | arm9, 487 | | ptr_mask::R, 488 | | ptr_mask::R | ptr_mask::W_16_32, ... | 494 | | 0x0680_0000 495 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 474 | / restore_region!( 475 | | arm9, 476 | | ptr_mask::R, 477 | | ptr_mask::R | ptr_mask::W_16_32, ... | 483 | | 0x0640_0000 484 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 463 | / restore_region!( 464 | | arm9, 465 | | ptr_mask::R, 466 | | ptr_mask::R | ptr_mask::W_16_32, ... | 472 | | 0x0660_0000 473 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L429
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:429:28 | 429 | && mapped & (mapped - 1) == 0 | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 452 | / restore_region!( 453 | | arm9, 454 | | ptr_mask::R, 455 | | ptr_mask::R | ptr_mask::W_16_32, ... | 461 | | 0x0620_0000 462 | | ); | |_____________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `restore_region` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 409 | / flush_usage!( 410 | | arm7, 17, 0, 411 | | ( 412 | | 0 => c, 0x1_FFFF, 413 | | 1 => d, 0x1_FFFF, 414 | | ) 415 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 402 | / flush_usage!( 403 | | b_obj, 17, 2, 404 | | ( 405 | | 0 => d, 0x1_FFFF, 406 | | 1 => i, 0x3FFF, 407 | | ) 408 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 394 | / flush_usage!( 395 | | b_bg, 15, 6, 396 | | ( 397 | | 0 => c, 0x1_FFFF, ... | 400 | | ) 401 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 384 | / flush_usage!( 385 | | a_obj, 14, 0x18, 386 | | ( 387 | | 0 => a, 0x1_FFFF, ... | 392 | | ) 393 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/gpu/vram/bank_cnt.rs#L321
warning: manually reimplementing `is_power_of_two` --> core/src/gpu/vram/bank_cnt.rs:321:40 | 321 | let clear = if mapped & (mapped - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `mapped.is_power_of_two()` ... 372 | / flush_usage!( 373 | | a_bg, 14, 0x60, 374 | | ( 375 | | 0 => a, 0x1_FFFF, ... | 382 | | ) 383 | | ); | |_________- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two = note: this warning originates in the macro `flush_usage` (in Nightly builds, run with -Z macro-backtrace for more info)
manually reimplementing `is_power_of_two`: core/src/cpu/interpreter/arm9/thumb/mem.rs#L544
warning: manually reimplementing `is_power_of_two` --> core/src/cpu/interpreter/arm9/thumb/mem.rs:544:8 | 544 | if instr as u8 & (instr as u8 - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `instr as u8.is_power_of_two()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two
manually reimplementing `is_power_of_two`: core/src/cpu/interpreter/arm9/thumb/mem.rs#L472
warning: manually reimplementing `is_power_of_two` --> core/src/cpu/interpreter/arm9/thumb/mem.rs:472:12 | 472 | if instr as u8 & (instr as u8 - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `instr as u8.is_power_of_two()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two
manually reimplementing `is_power_of_two`: core/src/cpu/interpreter/arm9/arm/mem.rs#L811
warning: manually reimplementing `is_power_of_two` --> core/src/cpu/interpreter/arm9/arm/mem.rs:811:12 | 811 | if instr as u16 & (instr as u16 - 1) == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `instr as u16.is_power_of_two()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two note: the lint level is defined here --> core/src/lib.rs:15:9 | 15 | #![warn(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::manual_is_power_of_two)]` implied by `#[warn(clippy::pedantic)]`

Artifacts

Produced during runtime
Name Size
macOS-app
5.66 MB
macOS-app-debug
6.91 MB
macOS-app-debug-gdb
7.05 MB