Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump embedded-hal to 1.0.0-rc.1 #6

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Bump embedded-hal to 1.0.0-rc.1 #6

merged 1 commit into from
Nov 4, 2023

Conversation

navaati
Copy link
Contributor

@navaati navaati commented Nov 4, 2023

Hi. esp-idf-hal implements [email protected] now, which causes incompatibility with this lib.
Of course I arrived at exactly the same result as PR #3 from @knightpp, not sure why it was closed, so I added them as Co-authored-by.

Co-authored-by: Danylo Kondratiev <[email protected]>
@navaati navaati marked this pull request as ready for review November 4, 2023 16:16
@kelnos
Copy link
Owner

kelnos commented Nov 4, 2023

looks good, thank you!

@kelnos kelnos merged commit 972e55e into kelnos:main Nov 4, 2023
9 checks passed
@navaati navaati deleted the patch-1 branch November 4, 2023 18:48
@navaati
Copy link
Contributor Author

navaati commented Nov 4, 2023

@kelnos ah, that was fast, thank you ! Shall I suggest cutting a release ^^" ? (I don't know how your process works)

@kelnos
Copy link
Owner

kelnos commented Nov 4, 2023

Ah, sorry, meant to comment back here: I released 0.3.0 after merging.

@kelnos
Copy link
Owner

kelnos commented Nov 4, 2023

Heh, looks like I forgot my own process and did the release manually. Oops.

@navaati
Copy link
Contributor Author

navaati commented Nov 5, 2023

Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants