Bogdan/generickey #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a simple prefix search
better reuse
single keys with no 0 padding caused index out-of-range
more idiomatic go, to use channels rather than callbacks
one more time, i think mismatch detection is working correctly now
adjusted interface to return the key, since we probably want to know …
dang, go fmt
Prefixchan
Need to handle the case where the search traversal gets you to a leaf node, but you haven't consumed the whole key. An example is the trivial case of one string and an empty prefix -- only a leaf node will be present, and the prefix doesn't consume the string. To handle this case I had the search helper return the leaf node in this case, which requires filtering out non-matching leaf nodes in the main Search method since now searchHelper will return false positives for prefix-matched leaves.
Was incorrect for the case where you partially match the prefix: this returns an index > 0 (one or more bytes matched) but less than prefixLen (not all bytes matched). Adding a test that failed prefix search before this fix.
As was already fixed for the other, more typical case, in iterating through the prefix and the key for the first mismatch, need to stop before exhausting the key and hitting an out-of-bounds crash.
Need to check if test key is exhausted while iterating over full key.
Fix a couple more prefix search issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.