Graceful http handling fixes #128 #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the git confusion... this is a clean PR.
Note that the undocumented
...was throwing warnings in the build.Testing this is tricky as it is both parallel and network required. It illustrates the need for us to get a stable set of http testing resources finalized. I stubbed my toe on using the docs folder since it doesn't deploy with pkgdown and we now have some diverse (and stale) urls in the tests.
So for now, the warning / retry stuff is not tested but it could be once we have that situation more cleaned up.