Standardize EN terminology for KO #2864
Open
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future it would be nice to give it a tooltip in `addIconsToDescription` too
|
"KOing" is that a real word ? I much prefer the originals that what you proposed |
I think the main thing for me is the "knocking down" terminology since it's used inconsistently and is a separate concept from "knocking out" just linguistically speaking. Myself and other new players have thought it to be a separate mechanic entirely. Do you think it would be worth changing that at least? |
|
Okay for replacing knocking down by knocking out 👍 It's mostly the KO'd and KOing forms that look weird to me |
valid! ill fix it soon 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future it would be nice to give it a tooltip in
addIconsToDescriptiontoo