Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok definitely pull this down and review this before merging.
With this PR I updated the Wiki to open within the Sidebar rather than in a modal. Idea is two-fold:
I wanted to make this update because there are many times where I want to search something during the match and the wiki modal can sometimes take too long to load while blocking my entire screen.
Some other updates bundled with this:
select
dropdownsOther sections have had images scaled down. Future improvements I'd like to make are:
select
I'm not totally sure, but I feel like Tabs might be resulting in some performance issues across the board. I know it's used widely and I don't totally have concrete proof other than the Pokemons section seems to be a bit faster now without it.
I did leave a lot of the old code for the modal wiki. I think in areas like the lobby it might make sense to use the modal, but I do like the aspect of being able to interact with the chat and join a game quickly with the wiki opened.
wiki-sidebar-1.mp4
wiki-sidebar-2.mp4
wiki-sidebar-3.mp4
wiki-sidebar-4.mp4