Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3 - some documentation improvements highlighted by @anjaliguptaz #29

Merged
merged 1 commit into from
Nov 4, 2019
Merged

#3 - some documentation improvements highlighted by @anjaliguptaz #29

merged 1 commit into from
Nov 4, 2019

Conversation

davemasselink
Copy link
Contributor

Related issue #3

Proposed Changes

  • explicitly listing a few dependencies
    • golang
    • minikube - as easiest option for starting with a well understood cluster

Testing Done

  • N/A - only dox changes

@davemasselink davemasselink requested a review from a team as a code owner October 31, 2019 17:26
@davemasselink
Copy link
Contributor Author

@anjaliguptaz, thanks for the documentation improvement suggestions in our recent convo

@davemasselink davemasselink self-assigned this Oct 31, 2019
@codecov
Copy link

codecov bot commented Oct 31, 2019 •
edited
Loading

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   11.85%   11.85%           
=======================================
  Files           4        4           
  Lines         194      194           
=======================================
  Hits           23       23           
  Misses        168      168           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb5b4a...3436c84. Read the comment docs.

pzou1974
pzou1974 approved these changes Nov 4, 2019
View reviewed changes
Copy link

@pzou1974 pzou1974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@davemasselink davemasselink merged commit b4896c0 into master Nov 4, 2019
@davemasselink davemasselink deleted the docs/readme-add-prereqs branch November 4, 2019 19:15
RaviHari pushed a commit to RaviHari/active-monitor that referenced this pull request Dec 21, 2020
@davemasselink @RaviHari
#3 - some documentation improvements highlighted by @anjaliguptaz (ke…
741fc68 
…ikoproj#29)

Signed-off-by: rhari <[email protected]>
RaviHari pushed a commit to RaviHari/active-monitor that referenced this pull request Dec 22, 2020
@davemasselink @RaviHari
#3 - some documentation improvements highlighted by @anjaliguptaz (ke…
d33b5b5 
…ikoproj#29)

Signed-off-by: Ravi Hari <[email protected]>
RaviHari pushed a commit to RaviHari/active-monitor that referenced this pull request Dec 22, 2020
@davemasselink @RaviHari
#3 - some documentation improvements highlighted by @anjaliguptaz (ke…
9abfe93 
…ikoproj#29)

Signed-off-by: RaviHari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzou1974 pzou1974 pzou1974 approved these changes

@kevdowney kevdowney kevdowney approved these changes

Assignees

@davemasselink davemasselink

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davemasselink @kevdowney @pzou1974