Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remind users of the maximum length of the attribute. #304

Merged
merged 5 commits into from
Feb 9, 2025

Conversation

mycrl
Copy link
Contributor

@mycrl mycrl commented Feb 6, 2025

No description provided.

Copy link
Owner

@keepsimple1 keepsimple1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! A couple of comments inline.

Copy link
Owner

@keepsimple1 keepsimple1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your update! Could you please add a test?

@mycrl
Copy link
Contributor Author

mycrl commented Feb 9, 2025

Added a simple text test. Considering the limited impact of this feature on functionality, no special treatment is required.

Copy link
Owner

@keepsimple1 keepsimple1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@keepsimple1 keepsimple1 merged commit 818f37c into keepsimple1:main Feb 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants