refactoring: property length check

keepsimple1 · Feb 10, 2025 · adf964f · adf964f
1 parent 818f37c
commit adf964f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/service_info.rs b/src/service_info.rs
@@ -721,13 +721,15 @@ fn encode_txt<'a>(properties: impl Iterator<Item = &'a TxtProperty>) -> Vec<u8>
         }
 
         // Property that exceed the length are truncated
-        if s.len() > u8::MAX as usize {
+        let sz: u8 = s.len().try_into().unwrap_or_else(|_| {
+            debug!("Property {} is too long, truncating to 255 bytes", prop.key);
             s.resize(u8::MAX as usize, 0);
-        }
+            u8::MAX
+        });
 
         // TXT uses (Length,Value) format for each property,
         // i.e. the first byte is the length.
-        bytes.push(s.len().try_into().unwrap());
+        bytes.push(sz);
         bytes.extend(s);
     }
     if bytes.is_empty() {