Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Going to application settings and back to entry view disables several context menu items #10981

Closed
Almandor opened this issue Jun 26, 2024 · 6 comments · Fixed by #11047
Closed
Assignees
Milestone

Comments

@Almandor
Copy link

Overview

I don't want the TOTP not being visible to anybody just looking on my screen. But when I disable the TOTP in the Preview the
TOTP and Copy Attribute elements in the context menu are grayed out.

Steps to Reproduce

  1. Add TOTP to one entry
  2. Open Settings - Security
  3. Select "Hide TOTP in the entry preview panel"
  4. Save the settings
  5. Right click on your Entry which has a TOTP
  6. Check status of TOTP and Copy Attribute

Expected Behavior

Should behave the same way as when the setting was not active. Both context menu entries should work.

Actual Behavior

Both context manu entries are disabled

Context

KeePassXC - Version 2.7.8
Revision: f6757d3
Distribution: Snap

Qt 5.15.11
Debugging mode is disabled.

Operating system: Ubuntu Core 22
CPU architecture: x86_64
Kernel: linux 6.8.0-35-generic

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • Passkeys
  • SSH Agent
  • KeeShare
  • YubiKey
  • Secret Service Integration

Cryptographic libraries:

  • Botan 2.19.1

Operating System: Linux - Ubuntu
Desktop Env: Gnome
Windowing System: Wayland

@Almandor Almandor added the bug label Jun 26, 2024
@varjolintu
Copy link
Member

varjolintu commented Jun 27, 2024

Seems if you disable the setting after enabling it, the context menu entries will not activate again.

@droidmonkey droidmonkey self-assigned this Jun 27, 2024
@droidmonkey droidmonkey added this to the v2.7.10 milestone Jun 27, 2024
@varjolintu
Copy link
Member

If you edit the entry, the context menu is brought back after leaving the dialog. When the error happens Entry::hasTotp() returns false, so something strange happens to m_data.totpSettings?

@droidmonkey
Copy link
Member

Just going into application settings and back out again disables the context menu entries. This has nothing to do with the TOTP preview panel settings.

@droidmonkey droidmonkey changed the title Disabling TOTP in the preview disables the context menu for copying the code Going to application settings and back to entry view disables several context menu items Jul 8, 2024
@0xdeadbeer
Copy link
Contributor

May I tackle down this issue and provide a solution?

@droidmonkey
Copy link
Member

droidmonkey commented Jul 8, 2024

Sure if you can find it, I am currently at a loss.

I just checked way back to 2.6.6 and the bug was still present. It seems to have gotten "worse" recently as 2.7.0 at least reset the state when you changed groups, that no longer happens. However, something is deeply flawed that is now becoming obvious.

@droidmonkey
Copy link
Member

droidmonkey commented Jul 8, 2024

@0xdeadbeer recommend stop work. I just brought forward a major update that I did to the menu actions and it fixed the issue immediately. Will post PR, but this change needs some attention to incorporate newer actions that appeared since I worked on this last.

#11047

droidmonkey added a commit that referenced this issue Jul 8, 2024
droidmonkey added a commit that referenced this issue Sep 1, 2024
droidmonkey added a commit that referenced this issue Sep 7, 2024
droidmonkey added a commit that referenced this issue Sep 7, 2024
droidmonkey added a commit that referenced this issue Sep 7, 2024
droidmonkey added a commit that referenced this issue Sep 8, 2024
droidmonkey added a commit that referenced this issue Sep 8, 2024
droidmonkey added a commit that referenced this issue Sep 8, 2024
droidmonkey added a commit that referenced this issue Sep 9, 2024
droidmonkey added a commit that referenced this issue Sep 9, 2024
@github-project-automation github-project-automation bot moved this to To triage in WIP Tracker Sep 23, 2024
@droidmonkey droidmonkey moved this from To triage to In review in WIP Tracker Sep 23, 2024
droidmonkey added a commit that referenced this issue Oct 7, 2024
droidmonkey added a commit that referenced this issue Oct 7, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in WIP Tracker Oct 7, 2024
droidmonkey added a commit that referenced this issue Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants