-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul action states and add icons to toolbar #11047
base: develop
Are you sure you want to change the base?
Conversation
Something I noticed while debugging: EDIT: Maybe the whole Preview Panel shouldn't get updated if it's not even visible. |
Consider grouping the new Database Settings toolbar icon into the existing Settings icon, with a dropdown. And in that case, you can remove the separator between the Passkeys and Password Generator, since these icons can be considered as just four tools: passkeys, reports, generator, settings. |
5fef845
to
bf44f82
Compare
3b7b666
to
135eedc
Compare
135eedc
to
2ce0ede
Compare
bd31d84
to
1f0525d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11047 +/- ##
===========================================
+ Coverage 62.97% 63.36% +0.39%
===========================================
Files 362 362
Lines 37783 37729 -54
===========================================
+ Hits 23793 23906 +113
+ Misses 13990 13823 -167 ☔ View full report in Codecov by Sentry. |
d24142a
to
389f740
Compare
@phoerious this is ready for review |
389f740
to
e591dbc
Compare
Screenshots
Testing strategy
Added unit tests and tested extensively manually
Type of change