Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent class hash #385

Merged
merged 11 commits into from
Sep 26, 2024
Merged

Fix inconsistent class hash #385

merged 11 commits into from
Sep 26, 2024

Conversation

ftheirs
Copy link
Collaborator

@ftheirs ftheirs commented Sep 26, 2024

Problem: for some Cairo0 contracts, computation from class_hash was incorrect. This was preventing from executing some new blocks that use old contracts

Solution: fix the hash computation

Issue Number: #379

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

@ftheirs ftheirs marked this pull request as ready for review September 26, 2024 16:19
Copy link
Collaborator

@HermanObst HermanObst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Collaborator

@notlesh notlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM. Was there also an issue on the Pathfinder side? If so, can you leave a link to an issue/PR about it here?

@ftheirs
Copy link
Collaborator Author

ftheirs commented Sep 26, 2024

Nice, LGTM. Was there also an issue on the Pathfinder side? If so, can you leave a link to an issue/PR about it here?

I searched the Pathfinder repo but haven't found any issues or PRs related to this

@ftheirs ftheirs merged commit 6d85daa into main Sep 26, 2024
6 checks passed
@ftheirs ftheirs deleted the ft/class_hash_test branch September 26, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants