Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: The enter syscall scopes hint is wrongly formatted. #381

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: The enter syscall scopes hint is wrongly formatted. #381

merged 1 commit into from
Sep 23, 2024

Conversation

whichqua
Copy link
Collaborator

Problem: The enter syscall scopes hint was wrongly formatted.
Solution: Fix to the expected state.

Issue Number: N/A

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

@whichqua whichqua changed the title The enter syscall scopes hint is wrongly formatted. fix: The enter syscall scopes hint is wrongly formatted. Sep 23, 2024
shamsasari
shamsasari approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@shamsasari shamsasari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM

cairo-lang Show resolved Hide resolved
@whichqua whichqua merged commit 05cb26b into main Sep 23, 2024
6 checks passed
@whichqua whichqua deleted the gm/fix-syscall-scopes-hint branch September 23, 2024 10:37
whichqua added a commit that referenced this pull request Sep 23, 2024
@whichqua
Revert "Problem: The enter syscall scopes hint was wrongly formatted. (…
31472b1 
…#381)"

This reverts commit 05cb26b.
@whichqua whichqua mentioned this pull request Sep 23, 2024
Merged
@HermanObst
Copy link
Collaborator

@whichqua this is a regression to cairo-lang 0.13.2.
The problem wasnt the formatting, but that 'component_hashes': os_input.declared_class_hash_to_component_hashes, (a new input for the OS) was added

cc @shamsasari

HermanObst pushed a commit that referenced this pull request Sep 23, 2024
@whichqua
Revert "Problem: The enter syscall scopes hint was wrongly formatted. (…
fc3c379 
…#381)" (#382)

This reverts commit 05cb26b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamsasari shamsasari shamsasari approved these changes

@HermanObst HermanObst Awaiting requested review from HermanObst HermanObst is a code owner

@notlesh notlesh Awaiting requested review from notlesh notlesh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whichqua @HermanObst @shamsasari