Fix: implement OsSingleStarknetStorage::new the right way
#157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
reviewed
Apr 12, 2024
Problem: the implementation of this method was a stub. Solution: port the Python implementation completely.
odesenfans
force-pushed
the
od/fix-os-single-starknet-storage-builder
branch
from
04674e8
to
547eb6d
Compare
notlesh
approved these changes
Apr 15, 2024
|
Not a fan either, but for now let's stick to the Python implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the implementation of this method was a stub.
Solution: port the Python implementation completely.
Issue Number: N/A
Type
Description
Breaking changes?