Convert to Cargo workspace #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
reviewed
Apr 10, 2024
| cairo-lang-filesystem = { workspace = true } | ||
| cairo-lang-semantic = { workspace = true } | ||
| cairo-lang-sierra = { workspace = true } | ||
| cairo-lang-syntax = { workspace = true } |
There was a problem hiding this comment.
I hadn't thought about this duplication. This limits the interest of the workspace. I'm not sure if this is the right way to go. What do you think?
There was a problem hiding this comment.
Agreed, it's a nuisance, and isn't very valuable with only a couple minor sub-crates. I'm rather indifferent.
These dependencies would be duplicated in any case, but it would be cleaner if the crate snos was in a subdir. We could make that change while we don't have many PRs open... 🤷
|
As decided, let's close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the project to a Cargo workspace structure.
The root
Cargo.tomlis a bit messy as each dependency is duplicated (this isn't exactly obvious from the diff); I think this is a consequence of having a crate in the root directory itself. This could be fixed by moving thesnoscrate to a subdir but that would be very disruptive.