Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: CHECK_*_RETURN_VALUE hints #128

Conversation

odesenfans
Copy link
Contributor

Implemented the following hints:

  • CHECK_SYSCALL_RETURN_VALUE
  • CHECK_NEW_SYSCALL_RETURN_VALUE
  • CHECK_NEW_DEPLOY_RETURN_VALUE

Issue Number: N/A

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

Copy link
Collaborator

@maciejka maciejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it already implemented in @notlesh reexecution pr?

Implemented the following hints:
* CHECK_SYSCALL_RETURN_VALUE
* CHECK_NEW_SYSCALL_RETURN_VALUE
* CHECK_NEW_DEPLOY_RETURN_VALUE
@odesenfans odesenfans merged commit 32fd1f0 into keep-starknet-strange:main Apr 4, 2024
5 checks passed
@odesenfans odesenfans deleted the od/check-return-value-hints branch April 4, 2024 10:16
odesenfans added a commit to Moonsong-Labs/snos that referenced this pull request Apr 11, 2024
Hints introduced in keep-starknet-strange#128 were deleted inadvertently. Reverted the
change.
odesenfans added a commit to Moonsong-Labs/snos that referenced this pull request Apr 11, 2024
Hints introduced in keep-starknet-strange#128 were deleted inadvertently. Reverted the
change.
odesenfans added a commit that referenced this pull request Apr 11, 2024
Hints introduced in #128 were deleted inadvertently. Reverted the
change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants