New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 3 unit tests, Refactored 1 test in test_swap_handler.cairo #603

Merged

Sk8erboi84 merged 1 commit into keep-starknet-strange:main from Akinbola247:main

Jan 21, 2024

Contributor

Akinbola247 commented Jan 15, 2024 •

edited

Loading

This PR is with respect to this issue #493
Please add the labels corresponding to the type of changes your PR introduces:

Testing

Given normal conditions, all tests are passing.

Below are my findings :

satoru/src/swap/swap_utils.cairo

Line 291 in e665cfe

if (_params.receiver != _params.market.market_token) {

when this condition (_params.receiver != _params.market.market_token) in the if statement block is being satisfied, it returns [input to long for argument] error.
satoru/src/swap/swap_utils.cairo

Line 183 in e665cfe

if (_params.token_in != _params.market.long_token

when this condition (_params.token_in != _params.market.long_token && _params.token_in != _params.market.short_token) in the if statement block is being satisfied, program crashes and runs into a panic error


          added 4 unit tests to swap_handler

2a9b185

Akinbola247 requested a review from AbdelStark as a code owner

January 15, 2024 21:20

Sk8erboi84 approved these changes

View reviewed changes

Sk8erboi84 merged commit d032c38 into keep-starknet-strange:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet