Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate 'Read-the-Docs' Modal on Kedro Docs Search #3371

Merged
merged 30 commits into from
Dec 11, 2023

Conversation

rashidakanchwala
Copy link
Contributor

@rashidakanchwala rashidakanchwala commented Nov 30, 2023

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Activate the 'read-the-docs' search modal when the user interacts with the search box on Kedro docs

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@rashidakanchwala rashidakanchwala changed the title Develop Activate 'Read-the-Docs' Modal on Kedro Docs Search" Nov 30, 2023
@rashidakanchwala rashidakanchwala marked this pull request as draft November 30, 2023 12:48
@rashidakanchwala rashidakanchwala changed the title Activate 'Read-the-Docs' Modal on Kedro Docs Search" Activate 'Read-the-Docs' Modal on Kedro Docs Search Nov 30, 2023
@astrojuanlu
Copy link
Member

Seemingly we're still affected by this: readthedocs/addons#205

See https://rashida-test-kedro.readthedocs.io/en/latest/

Screen Recording 2023-11-30 at 14 41 35

@astrojuanlu
Copy link
Member

Remaining: some CSS adjustments, see context in readthedocs/addons#175

@astrojuanlu
Copy link
Member

The CSS tweaks are not urgent though, they don't affect the search experience and can be done in a separate PR

@humitos
Copy link

humitos commented Nov 30, 2023

Seemingly we're still affected by this: readthedocs/addons#205

Thanks for reporting this issue to us. I've fixed it and deployed a newer version. I quickly tested in your project and I'm not able to reproduce it anymore. Let me know if it's working as you expected.

@astrojuanlu
Copy link
Member

Thanks a lot @humitos! I tested it and it seems to work. Feel free to unsubscribe from this thread, we'll take it from here.

@rashidakanchwala rashidakanchwala self-assigned this Dec 5, 2023
@rashidakanchwala rashidakanchwala marked this pull request as ready for review December 5, 2023 11:50
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @rashidakanchwala 🙏🏽

docs/source/_templates/layout.html Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
docs/source/_templates/layout.html Outdated Show resolved Hide resolved
@astrojuanlu astrojuanlu marked this pull request as draft December 5, 2023 13:25
@astrojuanlu
Copy link
Member

Reverting this to draft for now 👍🏽

@astrojuanlu astrojuanlu marked this pull request as ready for review December 6, 2023 17:51
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the two main changes:

  • ✔️ The readthedocs-search-show event gets triggered on search box focus
  • ✔️ The CSS looks exactly the same

We won't see the full effect until we enable the RTD add-ons in the project, which will happen to all versions. So, I say let's merge this PR already.

Thanks a lot @rashidakanchwala!

image

@astrojuanlu astrojuanlu mentioned this pull request Dec 11, 2023
7 tasks
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow I didn't know this was coming, looks amazing 🤩

@astrojuanlu astrojuanlu enabled auto-merge (squash) December 11, 2023 11:20
@astrojuanlu astrojuanlu merged commit 8cf869d into kedro-org:develop Dec 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants