-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate 'Read-the-Docs' Modal on Kedro Docs Search #3371
Conversation
Seemingly we're still affected by this: readthedocs/addons#205 |
Remaining: some CSS adjustments, see context in readthedocs/addons#175 |
The CSS tweaks are not urgent though, they don't affect the search experience and can be done in a separate PR |
Thanks for reporting this issue to us. I've fixed it and deployed a newer version. I quickly tested in your project and I'm not able to reproduce it anymore. Let me know if it's working as you expected. |
Thanks a lot @humitos! I tested it and it seems to work. Feel free to unsubscribe from this thread, we'll take it from here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @rashidakanchwala 🙏🏽
Reverting this to draft for now 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the two main changes:
- ✔️ The
readthedocs-search-show
event gets triggered on search box focus - ✔️ The CSS looks exactly the same
We won't see the full effect until we enable the RTD add-ons in the project, which will happen to all versions. So, I say let's merge this PR already.
Thanks a lot @rashidakanchwala!
![image](https://private-user-images.githubusercontent.com/316517/288503074-80936225-5986-4b7d-ba3e-4fdff2710c9b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NTk4MzYsIm5iZiI6MTczOTY1OTUzNiwicGF0aCI6Ii8zMTY1MTcvMjg4NTAzMDc0LTgwOTM2MjI1LTU5ODYtNGI3ZC1iYTNlLTRmZGZmMjcxMGM5Yi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQyMjQ1MzZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lOTA4N2IwN2JkZTI2MjRmZjIyZWRkNGI2ZTkxYzNiNjcxMTAyOGRmYzNmNGQ3MDFkYzQ2ZWU4OTdjMjU0MWYxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.jsdBwHB8hFvghe-OMdkFk_KcJMz09VsaeDiaHRZCO0o)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow I didn't know this was coming, looks amazing 🤩
Description
Activate the 'read-the-docs' search modal when the user interacts with the search box on Kedro docs
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file