-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs css to point to shared location #3205 #3206
Conversation
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Preview is here: https://kedro--3206.org.readthedocs.build/en/3206/ |
Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
This is currently what the documentation looks like on desktop and mobile: The desktop version is fine (just need to make sure the nav is consistent when the user clicks on a navigation item). The mobile version needs more work, as you can see above the mobile menu interaction is a little strange. I've created a quick design mockup below to illustrate expectations for mobile. Designs here. Changes proposed for mobile:
Additional changes for desktop (only if easy to change as further docs redesign will come later):
If changing the active-state colour from orange to black is too much effort, here is the orange version below. Please make sure the colour is the same across mobile as well. |
This is great, thank you! @vladimir-mck This is feedback for you and feel free to work on this branch. |
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Vladimir <[email protected]>
Signed-off-by: vladimir-mck <[email protected]>
Signed-off-by: vladimir-mck <[email protected]>
Signed-off-by: vladimir-mck <[email protected]>
Signed-off-by: vladimir-mck <[email protected]>
I'm not massively happy about adding a Kedro logo SVG file to the |
thank you for this @vladimir-mck! its looking really great - some design QA comments below:
|
Signed-off-by: vladimir-mck <[email protected]>
Signed-off-by: vladimir-mck <[email protected]>
Signed-off-by: vladimir-mck <[email protected]>
Add correct links to subprojects Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Closing this as it's done and merged in a separate PR |
Description
Mirrors changes in Viz docs
Development notes
Removed CSS files and pointed to S3 location. Added code for meganav
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file