-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SQLAlchemy import path #1251
Conversation
Signed-off-by: Antony Milne <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AntonyMilneQB! Changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, did you do a manual check that the deprecation warning is gone after these changes?
@jmholzer yep, I did and it's gone. |
so, as @AntonyMilneQB spotted, there seems to be a problem with the types:
(and then a bunch of errors that cascade from there). This is essentially an instance of dropbox/sqlalchemy-stubs#250. On the other hand, sqlalchemy 2.0 started shipping its own types sqlalchemy/sqlalchemy#6810 and I think The options are:
|
I find the warning sufficiently annoying that I think we should prioritise getting rid of it, since it appears not just when you run |
Signed-off-by: Antony Milne <[email protected]>
Closes #1244. As @astrojuanlu correctly observed, we haven't actually gotten rid of the deprecation warning, we just pinned the version. This alters the import path to actually fix it.
In fact, the version was already pinned before: #1222 didn't really do anything because the version specifier
~=1.4
is essentially the same as>=1.4, <2.0
. So I'm just reverting that to the~=
we had before, because it's more common in our codebase. Looking at the SQLAlchemy migration guide we could unpin this completely and just do>=1.4
but I've left the pin there for now just to be on the safe side (in general, I'd like to move towards more open-ended upper bounds, but that's for another time).