-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove support for python 3.9 #870
chore: remove support for python 3.9 #870
Conversation
91d80bd
to
be9da47
Compare
I think can also simplify https://github.com/felixscherz/kedro-plugins/blob/chore/remove-python-3.9/kedro-datasets/pyproject.toml#L230-L231; not sure if there are other such places. On a separate note (and this is in no way a reflection on this PR, which resolves the issue very well), I've started thinking more about #695, especially
While I was a big proponent of NEP-29, some experience on another project makes me wonder if we should hold off a bit, especially given almost nothing of value is gained through these changes (the typing changes are nice, but don't have any real impact...). I wouldn't be opposed to holding off a major version, unless somebody can point to more bad things we're doing right now to support 3.9. |
Thanks for having a look, good catch with the environment markers! I'll remove the one you referenced which seems to be the only one that deals with python 3.9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @felixscherz ! I'm still in favour of adhering to NEP-29, which is what we agreed on recently in backlog grooming as well.
@astrojuanlu I'm guessing you also still want to go ahead with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed to continue adhering to NEP 29 indeed! Thanks @felixscherz for this PR 🙌🏼
Approving to signal my acceptance although naturally the CI will need to be green
Thanks for the review! I'm having a look at the CI failures, it seems like they are failing on the EDIT: Seems like this is related to kedro itself removing support for python 3.8 kedro-org/kedro#4212. |
Signed-off-by: Felix Scherz <[email protected]>
Signed-off-by: Felix Scherz <[email protected]>
Signed-off-by: Felix Scherz <[email protected]>
Signed-off-by: Felix Scherz <[email protected]>
Signed-off-by: Felix Scherz <[email protected]>
Signed-off-by: Felix Scherz <[email protected]>
Signed-off-by: Felix Scherz <[email protected]>
Signed-off-by: Felix Scherz <[email protected]>
Signed-off-by: Felix Scherz <[email protected]>
06e24db
to
4aa1d29
Compare
@felixscherz Hey I am the author of kedro-org/kedro#4212. |
@kevin1kevin1k thank you! I opened an issue to deal with the removal of python 3.8: #872, we need to remove it from github actions but also make updates to the python syntax and update the |
Description
Hi, this is removing support for python 3.9 and updates the python syntax accordingly. Intended to resolve #818.
Development notes
typing.Union
in favor of|
operatortyping.Callable
in favor ofcollections.abc.Callable
Checklist
RELEASE.md
file