Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(datasets): use intersphinx over type_targets #801

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Aug 2, 2024

Description

#797 was an ugly approach I implemented due to release pressure/not having time to look into things. ;)

However, this is the right way to do things. For example, see how Response on API dataset actually links out now on https://kedro--801.org.readthedocs.build/projects/kedro-datasets/en/801/api/kedro_datasets.api.APIDataset.html#kedro_datasets.api.APIDataset.load (as compared to https://docs.kedro.org/projects/kedro-datasets/en/kedro-datasets-4.1.0/api/kedro_datasets.api.APIDataset.html#kedro_datasets.api.APIDataset.load).

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 🙏🏼

@astrojuanlu
Copy link
Member

Do you intend to do anything else about this @deepyaman ?

@deepyaman
Copy link
Member Author

Do you intend to do anything else about this @deepyaman ?

Sorry for the late reply. At some point, I intend to properly finish this (or, somebody else is free to take over). It's not a very high priority on my plate right now.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is tiny but also it's not anyone's priority to take over it. If the CI passes, I'd say we merge it.

@merelcht merelcht marked this pull request as ready for review January 15, 2025 14:43
@merelcht merelcht merged commit 2dc8f16 into main Jan 15, 2025
13 checks passed
@merelcht merelcht deleted the deepyaman-patch-1 branch January 15, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants