Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasets): fix SparkStreamingDataSet docstring #236

Merged
merged 10 commits into from
Jun 13, 2023
Merged

fix(datasets): fix SparkStreamingDataSet docstring #236

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
de107f8
fix malform docstring in SparkStreamingDataSet
noklam Jun 13, 2023
c419202
change indent
noklam Jun 13, 2023
6079395
Test without docstring
Jun 13, 2023
7a6042b
Add back docstring
Jun 13, 2023
e1edb09
Format docstring
Jun 13, 2023
aa32aa7
Merge branch 'main' into fix/setup-pickle
AhdraMeraliQB Jun 13, 2023
35d994d
Fix typo
Jun 13, 2023
e616485
Fix typo
AhdraMeraliQB Jun 13, 2023
998d7bc
Lint
Jun 13, 2023
8bf8f3d
Merge branch 'fix/setup-pickle' of github.com:kedro-org/kedro-plugins…
Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions kedro-datasets/kedro_datasets/spark/spark_streaming_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,16 @@ class SparkStreamingDataSet(AbstractDataSet):
`YAML API <https://kedro.readthedocs.io/en/stable/data/\
data_catalog.html#use-the-data-catalog-with-the-yaml-api>`_:
.. code-block:: yaml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, did you test it locally? Maybe open a PR on the framework side cherry picking this commit kedro-org/kedro@9c08611

raw.new_inventory:
type: streaming.extras.datasets.spark_streaming_dataset.SparkStreamingDataSet
filepath: data/01_raw/stream/inventory/
file_format: json
save_args:
type: spark.SparkStreamingDataSet
filepath: data/01_raw/stream/inventory/
file_format: json
save_args:
output_mode: append
checkpoint: data/04_checkpoint/raw_new_inventory
header: True
load_args:
load_args:
schema:
filepath: data/01_raw/schema/inventory_schema.json
"""
Expand Down