Skip to content

Commit

Permalink
chore: Move kedro-catalog JSON schema to kedro-datasets (#952)
Browse files Browse the repository at this point in the history
* Move kedro-catalog JSON schema to kedro-datasets #4258
* #4258 Update PR template
* Remove schemas for CachedDataset, MemoryDataset, and LambdaDataset since they remain in Kedro core
---------

Signed-off-by: Chris Schopp <[email protected]>
  • Loading branch information
chrisschopp authored Dec 12, 2024
1 parent 50fa3c0 commit 2df011c
Show file tree
Hide file tree
Showing 8 changed files with 5,730 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

- [ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
- [ ] Updated the documentation to reflect the code changes
- [ ] Updated `jsonschema/kedro-catalog-X.XX.json` if necessary
- [ ] Added a description of this change in the relevant `RELEASE.md` file
- [ ] Added tests to cover my changes
- [ ] Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)
2 changes: 1 addition & 1 deletion kedro-datasets/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ If you have new ideas for Kedro-Datasets then please open a [GitHub issue](https

If you're unsure where to begin contributing to Kedro-Datasets, please start by looking through the `good first issue` and `help wanted` on [GitHub](https://github.com/kedro-org/kedro-plugins/issues).
If you want to contribute a new dataset, read the [tutorial to create and contribute a custom dataset](https://docs.kedro.org/en/stable/data/how_to_create_a_custom_dataset.html) in the Kedro documentation.
Make sure to add the new dataset to `kedro_datasets.rst` so that it shows up in the API documentation and to `static/jsonschema/kedro-catalog-X.json` for IDE validation.
Make sure to add the new dataset to `kedro_datasets.rst` so that it shows up in the API documentation and to `kedro-datasets/static/jsonschema/kedro-catalog-X.json` for IDE validation.

Below is a guide to help you understand the process of contributing a new dataset, whether it falls under the category of core or experimental datasets.

Expand Down
2 changes: 2 additions & 0 deletions kedro-datasets/RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Implemented Snowflake's [local testing framework](https://docs.snowflake.com/en/developer-guide/snowpark/python/testing-locally) for testing purposes.
- Improved the dependency management for Spark-based datasets by refactoring the Spark and Databricks utility functions used across the datasets.
- Added deprecation warning for `tracking.MetricsDataset` and `tracking.JSONDataset`.
- Moved `kedro-catalog` JSON schemas from Kedro core to `kedro-datasets`.

## Breaking Changes

Expand All @@ -30,6 +31,7 @@ Many thanks to the following Kedroids for contributing PRs to this release:
- [Thomas d'Hooghe](https://github.com/tdhooghe)
- [Minura Punchihewa](https://github.com/MinuraPunchihewa)
- [Mark Druffel](https://github.com/mark-druffel)
- [Chris Schopp](https://github.com/chrisschopp)

# Release 5.1.0

Expand Down
1,202 changes: 1,202 additions & 0 deletions kedro-datasets/static/jsonschema/kedro-catalog-0.15.9.json

Large diffs are not rendered by default.

763 changes: 763 additions & 0 deletions kedro-datasets/static/jsonschema/kedro-catalog-0.16.json

Large diffs are not rendered by default.

950 changes: 950 additions & 0 deletions kedro-datasets/static/jsonschema/kedro-catalog-0.17.json

Large diffs are not rendered by default.

1,423 changes: 1,423 additions & 0 deletions kedro-datasets/static/jsonschema/kedro-catalog-0.18.json

Large diffs are not rendered by default.

1,388 changes: 1,388 additions & 0 deletions kedro-datasets/static/jsonschema/kedro-catalog-0.19.json

Large diffs are not rendered by default.

0 comments on commit 2df011c

Please sign in to comment.